Skip to content

[system] Sync system auth data stream with beats#695

Merged
marc-gr merged 1 commit intoelastic:masterfrom
marc-gr:system_auth-ecs-1.8
Feb 17, 2021
Merged

[system] Sync system auth data stream with beats#695
marc-gr merged 1 commit intoelastic:masterfrom
marc-gr:system_auth-ecs-1.8

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Feb 16, 2021

What does this PR do?

Syncs system auth data stream with changes made in beats

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 16, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr mentioned this pull request Feb 16, 2021
Closed
89 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 16, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #695 updated

  • Start Time: 2021-02-17T10:01:35.489+0000

  • Duration: 7 min 59 sec

  • Commit: 54bf096

Test stats 🧪

Test Results
Failed 0
Passed 184
Skipped 0
Total 184

Trends 🧪

Image of Build Times

Image of Tests

P1llus
P1llus approved these changes Feb 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comments only. Feel free to ignore them if you don't feel they include in the ECS work, we can work on them afterwards as well!

packages/system/data_stream/auth/_dev/test/pipeline/test-auth.log-expected.json Outdated
Copy link
Copy Markdown
Member

@P1llus P1llus Feb 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the year missing from these logs?

packages/system/data_stream/auth/agent/stream/log.yml.hbs Outdated
Copy link
Copy Markdown
Member

@P1llus P1llus Feb 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file sensitive to missing newlines?

@marc-gr marc-gr force-pushed the system_auth-ecs-1.8 branch from eab9ce9 to 54bf096 Compare February 17, 2021 10:01
@marc-gr marc-gr merged commit 88162eb into elastic:master Feb 17, 2021
@marc-gr marc-gr deleted the system_auth-ecs-1.8 branch February 17, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P1llus P1llus P1llus approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @P1llus