[google_workspace] Sync google_workspace data streams with beats#690
Merged
marc-gr merged 1 commit intoelastic:masterfrom Feb 17, 2021
Merged
[google_workspace] Sync google_workspace data streams with beats#690marc-gr merged 1 commit intoelastic:masterfrom
marc-gr merged 1 commit intoelastic:masterfrom
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
89 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
P1llus
approved these changes
Feb 16, 2021
Member
P1llus
left a comment
There was a problem hiding this comment.
LGTM, added some small comments, but since its not directly ECS related then maybe we should do it separately, rest is good :)
Comment on lines
+144
to
+145
| evt.Put("event.category", ["iam"]); | ||
| evt.Put("event.type", ["group"]); |
Member
There was a problem hiding this comment.
We might want to use append instead of put on these, as they are array fields. I see that its appended later on, but will this always happen?
Comment on lines
+144
to
+145
| evt.Put("event.type", ["start"]); | ||
| evt.Put("event.category", ["authentication", "session"]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Syncs google_workspace package with changes done in beats
Checklist