Skip to content

windows: set event.action to the event's sysmon name#6882

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:6761-windows
Jul 10, 2023
Merged

windows: set event.action to the event's sysmon name#6882
efd6 merged 1 commit intoelastic:mainfrom
efd6:6761-windows

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jul 9, 2023

What does this PR do?

Sets event.action to the event's sysmon name.

Event details from https://learn.microsoft.com/en-us/sysinternals/downloads/sysmon.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jul 9, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 9, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-09T23:45:47.381+0000

  • Duration: 16 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👍
Classes 87.5% (7/8) 👍
Methods 83.696% (77/92) 👍
Lines 92.858% (5188/5587) 👍 0.039
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review July 10, 2023 04:04
@efd6 efd6 requested review from a team as code owners July 10, 2023 04:04
@efd6 efd6 requested review from faec and ycombinator July 10, 2023 04:04
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 10, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 93bc803 into elastic:main Jul 10, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 10, 2023

Package windows - 1.26.0 containing this change is available at https://epr.elastic.co/search?package=windows

@andrewkroh
Copy link
Copy Markdown
Member

andrewkroh commented Jul 11, 2023

Thanks!

@efd6 efd6 deleted the 6761-windows branch February 5, 2025 22:05
@w0rk3r w0rk3r mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:windows Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @andrewkroh @taylor-swanson