Skip to content

[azure] Ensure url.path cannot be duplicated#6866

Merged
dmathieu merged 2 commits intomainfrom
unique-url-path
Jul 10, 2023
Merged

[azure] Ensure url.path cannot be duplicated#6866
dmathieu merged 2 commits intomainfrom
unique-url-path

Conversation

@dmathieu
Copy link
Copy Markdown
Member

@dmathieu dmathieu commented Jul 7, 2023

What does this PR do?

This is the same fix as in #5361, but for the url.path field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Open the dev tools and run the following query to simulate a request:

POST _ingest/pipeline/logs-azure.application_gateway-1.5.25/_simulate
{
  "docs": [
    {
      "_source": {
        "json": {
          "properties": {
            "requestUri": "https://example.com"
          }
        },
        "url": {
          "path": "https://elastic.co"
        }
      }
    }
  ]
}

Related issues

Screenshots

@dmathieu dmathieu added the bugfix Pull request that fixes a bug issue label Jul 7, 2023
@dmathieu dmathieu requested a review from a team as a code owner July 7, 2023 11:39
@dmathieu dmathieu changed the title Rnsure url.path cannot be duplicated Ensure url.path cannot be duplicated Jul 7, 2023
@dmathieu dmathieu mentioned this pull request Jul 7, 2023
Merged
4 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-07T11:39:26.037+0000

  • Duration: 14 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👍 20.447
Lines 84.971% (2810/3307) 👎 -14.474
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh changed the title Ensure url.path cannot be duplicated [azure] Ensure url.path cannot be duplicated Jul 7, 2023
@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 7, 2023
@dmathieu dmathieu merged commit 2b9a514 into main Jul 10, 2023
@dmathieu dmathieu deleted the unique-url-path branch July 10, 2023 08:05
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 10, 2023

Package azure - 1.5.25 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdancheva tdancheva tdancheva approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue Integration:azure Azure Logs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmathieu @elasticmachine @tdancheva @andrewkroh