Skip to content

[cisco] Sync ftd and asa data streams with beats#686

Merged
marc-gr merged 1 commit intoelastic:masterfrom
marc-gr:cisco-ecs-1.8
Feb 17, 2021
Merged

[cisco] Sync ftd and asa data streams with beats#686
marc-gr merged 1 commit intoelastic:masterfrom
marc-gr:cisco-ecs-1.8

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Feb 15, 2021

What does this PR do?

Syncs ftd and asa data streams with latest changes from beats module

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-02-16T22:28:09.899+0000

  • Duration: 34 min 39 sec

  • Commit: 18aa439

Test stats 🧪

Test Results
Failed 0
Passed 108
Skipped 0
Total 108

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Copy Markdown
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some small comments in case it was missed or wrong.

"event": {
"severity": 6,
"ingested": "2021-01-28T23:44:33.971787100Z",
"ingested": "2021-02-15T11:59:05.289395610Z",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the timestamps are updated, are they ignored during golden file checks only, or should they be ignored during the creation of the golden files as well?

name: cisco
title: Cisco
version: 0.7.7
version: 0.7.8
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that the Winlogbeat package increase in a minor version, while this increases in a bugfix version, is there any specifications on this?

@marc-gr marc-gr merged commit 3f61223 into elastic:master Feb 17, 2021
@marc-gr marc-gr deleted the cisco-ecs-1.8 branch February 17, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants