Skip to content

[azure] Handle DNAT log with policy/rgc/rc/rule attributes#6824

Merged
dmathieu merged 5 commits intomainfrom
azure-firewall-dnat
Jul 5, 2023
Merged

[azure] Handle DNAT log with policy/rgc/rc/rule attributes#6824
dmathieu merged 5 commits intomainfrom
azure-firewall-dnat

Conversation

@dmathieu
Copy link
Copy Markdown
Member

@dmathieu dmathieu commented Jul 5, 2023 •
edited
Loading

What does this PR do?

DNAT log entries from Azure may include the Policy, Rule Collection Group, Rule Collection and Rule attributes.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Install the plugin, and generate firewall requests that get DNAT'ed.
This is also unit tested with the expected json tests.

Related issues

Screenshots

@dmathieu dmathieu added the bugfix Pull request that fixes a bug issue label Jul 5, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 5, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-05T14:12:52.525+0000

  • Duration: 14 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 5, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) ❕
Classes 86.364% (19/22) ❕
Methods 83.333% (155/186) ❕
Lines 84.939% (2803/3300) ❕
Conditionals 100.0% (0/0) 💚

@dmathieu dmathieu force-pushed the azure-firewall-dnat branch from 661bcbe to 0233e7f Compare July 5, 2023 14:12
@dmathieu dmathieu marked this pull request as ready for review July 5, 2023 14:30
@dmathieu dmathieu requested a review from a team as a code owner July 5, 2023 14:30
tdancheva
tdancheva approved these changes Jul 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tdancheva tdancheva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I looked at the SDH, should solve one of the issues.

@dmathieu dmathieu merged commit 5529bb2 into main Jul 5, 2023
@dmathieu dmathieu deleted the azure-firewall-dnat branch July 5, 2023 19:03
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 5, 2023

Package azure - 1.5.24 containing this change is available at https://epr.elastic.co/search?package=azure

@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 5, 2023
@andrewkroh andrewkroh changed the title Handle DNAT log with policy/rgc/rc/rule attributes [azure] Handle DNAT log with policy/rgc/rc/rule attributes Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdancheva tdancheva tdancheva approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue Integration:azure Azure Logs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmathieu @elasticmachine @tdancheva @andrewkroh