AWS package: revert back change to dynamic_dataset/namespace#6806
AWS package: revert back change to dynamic_dataset/namespace#6806gsantoro wants to merge 2 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
| @@ -196,6 +196,3 @@ streams: | |||
| title: Dataset name | |||
There was a problem hiding this comment.
This has a dataset config. Maybe this one needs to keep routing? @felixbarny
There was a problem hiding this comment.
Yeah, I guess so, but I don't really know what this data stream is doing. Is it monitoring cloud watch itself or is it an input for logs coming via cloud watch?
What's the difference between this and the aws_logs package?
There was a problem hiding this comment.
Maybe someone from @elastic/obs-cloud-monitoring can chime in.
What I can see from the aws.cloudwatch_logs/manifest.yml
title: AWS CloudWatch logs via S3 (Deprecated)
description: (Deprecated) Please use Custom AWS Logs integration instead
this datastream was ingesting cloudwatch logs from s3 and it might be deprecated in favour of aws_log.generic datastream-based integraiton. I believe this last one might need to be an input package instead, according to the definition used in our last meetin @ruflin .
There was a problem hiding this comment.
We are removing this option (reading logs in cloudwatch via s3) since it does not make sense. If the user has logs in cloudwatch already, then aws-cloudwatch input should be used. There is no need to route all logs to S3 from cloudwatch and then ingest them with aws-s3 input. This option is marked as deprecated for a while and we will remove it soon.
|
I had a chat with @girodav about this PR since he approved the related one on aws_logs. He told me that he is not 100% of this change. Personally, I would keep the routing in place and close this PR without merging. @felixbarny ? |
|
sgtm |
|
Given the discussion at #6806 (comment) and the fact that one of the datastream is still active (not deprecated), we decided to keep this change in place and to NOT merge this PR |
What does this PR do?
Revert back changes from issue elastic/kibana#157897.
Removing the following configs from the system package manifest
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots