Skip to content

[AWS] Enable TSDB for some metric datasets - Part 1#6782

Merged
constanca-m merged 2 commits intoelastic:mainfrom
constanca-m:1-aws-dimensions
Jul 4, 2023
Merged

[AWS] Enable TSDB for some metric datasets - Part 1#6782
constanca-m merged 2 commits intoelastic:mainfrom
constanca-m:1-aws-dimensions

Conversation

@constanca-m
Copy link
Copy Markdown
Contributor

@constanca-m constanca-m commented Jul 3, 2023

What does this PR do?

Enable time series data streams for the metrics datasets:

  • Billing
  • DynamoDB
  • EBS
  • ECS
  • ELB
  • Firewall
  • Kinesis
  • Lambda
  • NAT gateway
  • RDS
  • Redshift
  • S3 Storage Lens
  • SNS
  • SQS
  • Transit Gateway
  • VPN.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6293.

@constanca-m
Enable TSDB
1f0a37c 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m self-assigned this Jul 3, 2023
@constanca-m constanca-m requested a review from a team as a code owner July 3, 2023 10:28
@constanca-m
Update changelog
5fe061c 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 3, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-03T10:28:39.519+0000

  • Duration: 53 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 3, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) ❕
Classes 93.75% (15/16) ❕
Methods 85.714% (240/280) ❕
Lines 85.925% (7387/8597) ❕
Conditionals 100.0% (0/0) 💚

@lalit-satapathy
Copy link
Copy Markdown
Contributor

lalit-satapathy commented Jul 3, 2023

@constanca-m,

For data_stream vpn, the dimension fileds are define here. The dimension fields are missing in the sample event. Are they not needed in the sample event?

@constanca-m
Copy link
Copy Markdown
Contributor Author

constanca-m commented Jul 3, 2023

@lalit-satapathy Not every dimension is present in every document. There were a few changes on the dimensions.* fields, but that was a different PR: #6648. I didn't change the sample event since that is not related to TSDB.

@constanca-m constanca-m mentioned this pull request Jul 3, 2023
Closed
@lalit-satapathy
Copy link
Copy Markdown
Contributor

lalit-satapathy commented Jul 3, 2023

@elastic/obs-cloud-monitoring even dimension fields missing in elb_metrics sample events. Is that accidental, May be that should be addressed separately?

lalit-satapathy
lalit-satapathy approved these changes Jul 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for TSDB release; except for the outdated sample events issue highlighted before.

endorama
endorama approved these changes Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to allow releasing TSDB but I'd like to look into the sample events more, as they are a valuable tool and I feel we need improvements in that area.

@constanca-m constanca-m merged commit f90374f into elastic:main Jul 4, 2023
@constanca-m constanca-m deleted the 1-aws-dimensions branch July 4, 2023 08:03
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 4, 2023

Package aws - 1.46.0 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@endorama endorama endorama approved these changes

@gizas gizas gizas approved these changes

@lalit-satapathy lalit-satapathy lalit-satapathy approved these changes

Assignees

@constanca-m constanca-m

Labels

Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@constanca-m @elasticmachine @lalit-satapathy @endorama @gizas