Skip to content

m*: ensure event.kind is correctly set for pipeline errors#6661

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:6582-m
Jun 22, 2023
Merged

m*: ensure event.kind is correctly set for pipeline errors#6661
efd6 merged 1 commit intoelastic:mainfrom
efd6:6582-m

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jun 22, 2023 •
edited
Loading

What does this PR do?

Modify m365_defender, mattermost, microsoft_defender_endpoint, microsoft_dhcp, microsoft_exchange_online_message_trace and mysql_enterprise to correctly set event.kind for pipeline errors and ensure error.message is an array.

modsecurity is omitted as there is a pending PR to fix ingest in that package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6
m*: ensure event.kind is correctly set for pipeline errors
9c177af 
m365_defender, mattermost, microsoft_defender_endpoint, microsoft_dhcp,
microsoft_exchange_online_message_trace, mysql_enterprise
@efd6 efd6 self-assigned this Jun 22, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-22T02:07:50.633+0000

  • Duration: 15 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 mentioned this pull request Jun 22, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (14/14) 💚 77.778
Classes 100.0% (14/14) 💚 77.778
Methods 93.293% (153/164) 👍 59.959
Lines 92.213% (6371/6909) 👍 69.206
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 22, 2023 02:33
@efd6 efd6 requested a review from a team as a code owner June 22, 2023 02:33
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

bhapas
bhapas approved these changes Jun 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit ba494d3 into elastic:main Jun 22, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package m365_defender - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=m365_defender

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package mattermost - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=mattermost

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package microsoft_defender_endpoint - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package microsoft_dhcp - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_dhcp

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package microsoft_exchange_online_message_trace - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_exchange_online_message_trace

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package mysql_enterprise - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=mysql_enterprise

@andrewkroh andrewkroh added Integration:m365_defender Microsoft Defender XDR Integration:mattermost Mattermost (Community supported) Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:microsoft_dhcp Microsoft DHCP Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace Integration:mysql_enterprise MySQL Enterprise labels Jul 22, 2024
@efd6 efd6 deleted the 6582-m branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:m365_defender Microsoft Defender XDR Integration:mattermost Mattermost (Community supported) Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:microsoft_dhcp Microsoft DHCP Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace Integration:mysql_enterprise MySQL Enterprise

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @bhapas @andrewkroh