Skip to content

[zscaler_zpa] Ensure event.kind is correctly set for pipeline errors#6651

Merged
efd6 merged 4 commits intoelastic:mainfrom
MakoWish:6582-zscaler_zpa
Jun 21, 2023
Merged

[zscaler_zpa] Ensure event.kind is correctly set for pipeline errors#6651
efd6 merged 4 commits intoelastic:mainfrom
MakoWish:6582-zscaler_zpa

Conversation

@MakoWish
Copy link
Copy Markdown
Contributor

@MakoWish MakoWish commented Jun 21, 2023

What does this PR do?

Modify zscaler_zpa integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner June 21, 2023 22:36
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T23:12:38.702+0000

  • Duration: 18 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Jun 21, 2023

/test

@efd6 efd6 mentioned this pull request Jun 21, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (59/59) 💚 5.238
Lines 90.278% (1560/1728) 👎 -5.194
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 4f52db0 into elastic:main Jun 21, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package zscaler_zpa - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

@MakoWish MakoWish deleted the 6582-zscaler_zpa branch June 22, 2023 14:23
@andrewkroh andrewkroh added the Integration:zscaler_zpa Zscaler Private Access label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

Integration:zscaler_zpa Zscaler Private Access

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MakoWish @elasticmachine @efd6 @andrewkroh