[network_traffic] Ensure event.kind is correctly set for pipeline errors#6641
Merged
efd6 merged 4 commits intoelastic:mainfrom Jun 21, 2023
MakoWish:6582-network_traffic
Merged
[network_traffic] Ensure event.kind is correctly set for pipeline errors#6641efd6 merged 4 commits intoelastic:mainfrom MakoWish:6582-network_traffic
efd6 merged 4 commits intoelastic:mainfrom
MakoWish:6582-network_traffic
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
Contributor
|
/test |
🌐 Coverage report
|
efd6
approved these changes
Jun 21, 2023
Comment on lines
+53
to
+59
| - append: | ||
| field: error.message | ||
| value: |- | ||
| Processor "{{ _ingest.on_failure_processor_type }}" with tag "{{ _ingest.on_failure_processor_tag }}" in pipeline "{{ _ingest.on_failure_pipeline }}" failed with message "{{ _ingest.on_failure_message }}" | ||
| - set: | ||
| field: event.kind | ||
| value: pipeline_error |
Contributor
There was a problem hiding this comment.
Normally, we'd keep the formatting consistent with the rest in the file. This is not an error condition and there would be a lot of work here to make this cosmetic change, so we'll let it pass.
|
Package network_traffic - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=network_traffic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modify network_traffic integration to correctly set
event.kindfor pipeline errors and ensureerror.messageis an array.Checklist
Author's Checklist
How to test this PR locally
Related issues
Screenshots