Skip to content

[Suricata] Ensure event.kind is correctly set for pipeline errors#6625

Merged
efd6 merged 4 commits intoelastic:mainfrom
MakoWish:6582-suricata
Jun 20, 2023
Merged

[Suricata] Ensure event.kind is correctly set for pipeline errors#6625
efd6 merged 4 commits intoelastic:mainfrom
MakoWish:6582-suricata

Conversation

@MakoWish
Copy link
Copy Markdown
Contributor

@MakoWish MakoWish commented Jun 20, 2023

What does this PR do?

Modify suricata integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner June 20, 2023 17:03
@MakoWish MakoWish changed the title 6582 suricata [Suricata] Ensure event.kind is correctly set for pipeline errors #6612 Jun 20, 2023
@MakoWish MakoWish changed the title [Suricata] Ensure event.kind is correctly set for pipeline errors #6612 [Suricata] Ensure event.kind is correctly set for pipeline errors Jun 20, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T21:28:31.288+0000

  • Duration: 15 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Jun 20, 2023

/test

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (5/5) 💚 5.172
Classes 100.0% (5/5) 💚 5.172
Methods 100.0% (44/44) 💚 4.332
Lines 95.94% (827/862) 👍 4.978
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit bb70c15 into elastic:main Jun 20, 2023
@efd6 efd6 mentioned this pull request Jun 20, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package suricata - 2.9.0 containing this change is available at https://epr.elastic.co/search?package=suricata

@MakoWish MakoWish deleted the 6582-suricata branch June 21, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

Integration:suricata Suricata

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MakoWish @elasticmachine @efd6 @andrewkroh