Skip to content

[jkl]*: ensure event.kind is correctly set for pipeline errors#6617

Merged
efd6 merged 2 commits intoelastic:mainfrom
efd6:6582-jkl
Jun 21, 2023
Merged

[jkl]*: ensure event.kind is correctly set for pipeline errors#6617
efd6 merged 2 commits intoelastic:mainfrom
efd6:6582-jkl

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jun 20, 2023

What does this PR do?

Modify jumpcloud, juniper_junos, juniper_netscreen, juniper_srx, keycloak, lastpass and lyve_cloud to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 20, 2023
@efd6
[jkl]*: ensure event.kind is correctly set for pipeline errors
9b1307c 
jumpcloud, juniper_junos, juniper_netscreen, juniper_srx, keycloak, lastpass and
lyve_cloud
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T22:09:22.022+0000

  • Duration: 17 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 50
Skipped 0
Total 50

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 mentioned this pull request Jun 20, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (10/10) 💚
Classes 100.0% (10/10) 💚
Methods 91.228% (104/114) 👎 -5.671
Lines 87.836% (1372/1562) 👎 -7.423
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 20, 2023 06:40
@efd6 efd6 requested a review from a team as a code owner June 20, 2023 06:40
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 426911d into elastic:main Jun 21, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package jumpcloud - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=jumpcloud

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package juniper_junos - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=juniper_junos

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package juniper_netscreen - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=juniper_netscreen

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package keycloak - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=keycloak

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package lastpass - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=lastpass

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package lyve_cloud - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=lyve_cloud

@andrewkroh andrewkroh added Integration:jumpcloud JumpCloud (Community supported) Integration:juniper_junos Juniper JunOS (Deprecated) Integration:juniper_netscreen Juniper NetScreen (Deprecated) Integration:keycloak Keycloak (Community supported) Integration:lastpass LastPass Integration:lyve_cloud Lyve Cloud (Partner supported) labels Jul 22, 2024
@efd6 efd6 deleted the 6582-jkl branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgeller kgeller kgeller approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:jumpcloud JumpCloud (Community supported) Integration:juniper_junos Juniper JunOS (Deprecated) Integration:juniper_netscreen Juniper NetScreen (Deprecated) Integration:keycloak Keycloak (Community supported) Integration:lastpass LastPass Integration:lyve_cloud Lyve Cloud (Partner supported)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @kgeller @andrewkroh