Skip to content

jamf_compliance_reporter: ensure event.kind is correctly set for pipeline errors#6615

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:6582-jamf
Jun 21, 2023
Merged

jamf_compliance_reporter: ensure event.kind is correctly set for pipeline errors#6615
efd6 merged 1 commit intoelastic:mainfrom
efd6:6582-jamf

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jun 20, 2023

What does this PR do?

Modify jamf_compliance_reporter to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 20, 2023
@efd6 efd6 mentioned this pull request Jun 20, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T02:02:15.505+0000

  • Duration: 16 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (47/47) 💚 2.97
Classes 100.0% (47/47) 💚 2.97
Methods 100.0% (156/156) 💚 7.849
Lines 99.321% (3072/3093) 👍 7.405
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 20, 2023 02:19
@efd6 efd6 requested a review from a team as a code owner June 20, 2023 02:19
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit bff969e into elastic:main Jun 21, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package jamf_compliance_reporter - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=jamf_compliance_reporter

@andrewkroh andrewkroh added the Integration:jamf_compliance_reporter Jamf Compliance Reporter label Jul 22, 2024
@efd6 efd6 deleted the 6582-jamf branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgeller kgeller kgeller approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:jamf_compliance_reporter Jamf Compliance Reporter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @kgeller @andrewkroh