Skip to content

[dfg]*: ensure event.kind is correctly set for pipeline errors#6614

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:6582-dfg
Jun 20, 2023
Merged

[dfg]*: ensure event.kind is correctly set for pipeline errors#6614
efd6 merged 1 commit intoelastic:mainfrom
efd6:6582-dfg

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jun 20, 2023

What does this PR do?

Modify darktrace, f5, f5_bigip, fim, fireeye, forcepoint_web, fortinet_forticlient, fortinet_fortiedr, fortinet_fortigate, fortinet_fortimail, gcp, github and google_workspace to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 20, 2023
@efd6 efd6 mentioned this pull request Jun 20, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T21:26:26.271+0000

  • Duration: 27 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 321
Skipped 0
Total 321

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (37/37) 💚
Files 100.0% (52/52) 💚 5.172
Classes 100.0% (52/52) 💚 5.172
Methods 96.26% (592/615) 👍 0.592
Lines 93.811% (15187/16189) 👍 2.849
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 20, 2023 01:36
@efd6 efd6 requested review from a team as code owners June 20, 2023 01:36
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
[dfg]*: ensure event.kind is correctly set for pipeline errors
14c25f4 
darktrace, f5, f5_bigip, fim, fireeye, forcepoint_web, fortinet_forticlient,
fortinet_fortiedr, fortinet_fortigate, fortinet_fortimail, gcp, github and
google_workspace
@efd6 efd6 merged commit 2ca9c42 into elastic:main Jun 20, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package darktrace - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=darktrace

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package f5 - 0.16.0 containing this change is available at https://epr.elastic.co/search?package=f5

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package f5_bigip - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=f5_bigip

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package fim - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=fim

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package fireeye - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=fireeye

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package forcepoint_web - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=forcepoint_web

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package fortinet_forticlient - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_forticlient

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package fortinet_fortiedr - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortiedr

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package fortinet_fortigate - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package fortinet_fortimail - 2.4.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortimail

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package gcp - 2.22.0 containing this change is available at https://epr.elastic.co/search?package=gcp

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package github - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=github

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package google_workspace - 2.10.0 containing this change is available at https://epr.elastic.co/search?package=google_workspace

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 19, 2023

Package gcp - 2.22.1 containing this change is available at https://epr.elastic.co/search?package=gcp

@efd6 efd6 deleted the 6582-dfg branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgeller kgeller kgeller approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @kgeller