Skip to content

c*: ensure event.kind is correctly set for pipeline errors#6613

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:6572-c
Jun 20, 2023
Merged

c*: ensure event.kind is correctly set for pipeline errors#6613
efd6 merged 1 commit intoelastic:mainfrom
efd6:6572-c

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jun 19, 2023 •
edited
Loading

What does this PR do?

Modify carbon_black_cloud, carbonblack_edr, cef, citrix_waf, cloudflare, cloudflare_logpush, crowdstrike and cylance to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 19, 2023
@efd6 efd6 mentioned this pull request Jun 19, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 19, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T21:21:21.236+0000

  • Duration: 21 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 116
Skipped 0
Total 116

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 19, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (13/13) 💚
Files 100.0% (25/25) 💚
Classes 100.0% (25/25) 💚
Methods 96.93% (221/228) 👍 71.93
Lines 94.116% (6478/6883) 👎 -5.884
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 20, 2023 01:01
@efd6 efd6 requested a review from a team as a code owner June 20, 2023 01:01
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
c*: ensure event.kind is correctly set for pipeline errors
c4229da 
carbon_black_cloud, carbonblack_edr, cef, citrix_waf, cloudflare,
crowdstrike and cylance
@efd6 efd6 merged commit 69753e1 into elastic:main Jun 20, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package carbon_black_cloud - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package carbonblack_edr - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=carbonblack_edr

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cef - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=cef

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package citrix_waf - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=citrix_waf

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package cloudflare - 2.9.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package crowdstrike - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=crowdstrike

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2023

Package cylance - 0.16.0 containing this change is available at https://epr.elastic.co/search?package=cylance

@andrewkroh andrewkroh added Integration:carbon_black_cloud VMware Carbon Black Cloud Integration:carbonblack_edr VMware Carbon Black EDR Integration:cef Common Event Format (CEF) Integration:citrix_waf Citrix Web App Firewall Integration:cloudflare Cloudflare (Community supported) Integration:crowdstrike CrowdStrike Integration:cylance CylanceProtect Logs (Deprecated) labels Jul 22, 2024
@efd6 efd6 deleted the 6572-c branch February 5, 2025 22:08
@github-actions github-actions bot mentioned this pull request Feb 25, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgeller kgeller kgeller approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:carbon_black_cloud VMware Carbon Black Cloud Integration:carbonblack_edr VMware Carbon Black EDR Integration:cef Common Event Format (CEF) Integration:citrix_waf Citrix Web App Firewall Integration:cloudflare Cloudflare (Community supported) Integration:crowdstrike CrowdStrike Integration:cylance CylanceProtect Logs (Deprecated)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @kgeller @andrewkroh