Skip to content

[System] GA release for time_series index.mode#6607

Merged
mrodm merged 3 commits intoelastic:mainfrom
tetianakravchenko:system-package-tsdb-release
Jun 22, 2023
Merged

[System] GA release for time_series index.mode#6607
mrodm merged 3 commits intoelastic:mainfrom
tetianakravchenko:system-package-tsdb-release

Conversation

@tetianakravchenko
Copy link
Copy Markdown
Contributor

@tetianakravchenko tetianakravchenko commented Jun 19, 2023 •
edited
Loading

What does this PR do?

Add a changelog record to the system package regarding the enablement of TSDB, add the doc regarding the time series index mode.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tetianakravchenko
add a changelog regarding the TSDB
e110096 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
fix PR link; add an info regarding the time series index mode to readme
ebb0100 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko marked this pull request as ready for review June 19, 2023 15:06
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner June 19, 2023 15:06
lalit-satapathy
lalit-satapathy approved these changes Jun 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since GA was already enabled. This does it cleanly now.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 19, 2023 •
edited
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T10:03:03.309+0000

  • Duration: 14 min 59 sec

Steps errors 3

Expand to view the steps failures

Test integration: system
  • Took 1 min 35 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 19, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 5.882% (1/17) 👎 -94.118
Lines 100.0% (0/0) 💚 7.839
Conditionals 100.0% (0/0) 💚

@tetianakravchenko
Copy link
Copy Markdown
Contributor Author

tetianakravchenko commented Jun 20, 2023

/test

@tetianakravchenko
remove documentation changes as agreed
e69d7ea 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
Copy link
Copy Markdown
Contributor Author

tetianakravchenko commented Jun 20, 2023

/test

1 similar comment
@tetianakravchenko
Copy link
Copy Markdown
Contributor Author

tetianakravchenko commented Jun 21, 2023

/test

@tetianakravchenko
Copy link
Copy Markdown
Contributor Author

tetianakravchenko commented Jun 21, 2023

FYI: tests are failing with the error:

Error: error running package system tests: could not complete test run: failed to tear down runner: failed to uninstall package: can't remove the package: could not remove package; API status code = 400; response body = {"statusCode":400,"error":"Bad Request","message":"unable to remove package with existing package policy(s) in use by agent(s)"}

fix - elastic/elastic-package#1315, waiting for the next elastic-package release

@mrodm
Copy link
Copy Markdown
Collaborator

mrodm commented Jun 22, 2023

Merging this PR.

This failure is related to an issue solved by this elastic-package PR elastic/elastic-package#1315 . It was also checked that tests for this package are run successfully with a previous version of elastic-package

cc @tetianakravchenko

@mrodm mrodm merged commit 5d158cb into elastic:main Jun 22, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2023

Package system - 1.34.0 containing this change is available at https://epr.elastic.co/search?package=system

@ebeahan ebeahan mentioned this pull request Jun 26, 2023
Merged
4 tasks
@lalit-satapathy lalit-satapathy mentioned this pull request Jun 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalit-satapathy lalit-satapathy lalit-satapathy approved these changes

Assignees

No one assigned

Labels

Integration:system System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tetianakravchenko @elasticmachine @mrodm @lalit-satapathy @andrewkroh