Skip to content

cisco*: ensure event.kind is correctly set for pipeline errors#6600

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:6582-cisco
Jun 20, 2023
Merged

cisco*: ensure event.kind is correctly set for pipeline errors#6600
efd6 merged 1 commit intoelastic:mainfrom
efd6:6582-cisco

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jun 19, 2023

What does this PR do?

Modify cisco_aironet, cisco_asa, cisco_duo, cisco_ftd, cisco_ise, cisco_meraki, cisco_nexus, cisco_secure_email_gateway, cisco_secure_endpoint and cisco_umbrella to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 19, 2023
@efd6 efd6 mentioned this pull request Jun 19, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 19, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-19T06:47:13.074+0000

  • Duration: 18 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 199
Skipped 0
Total 199

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 19, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 96.0% (48/50) 👎 -4.0
Classes 96.0% (48/50) 👎 -4.0
Methods 98.052% (453/462) 👎 -0.666
Lines 90.188% (11976/13279) 👎 -5.838
Conditionals 100.0% (0/0) 💚

@efd6
cisco*: ensure event.kind is correctly set for pipeline errors
6349aa1 
cisco_aironet, cisco_asa, cisco_duo, cisco_ftd, cisco_ise, cisco_meraki,
cisco_nexus, cisco_secure_email_gateway, cisco_secure_endpoint and
cisco_umbrella.
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 19, 2023

💚 Build Succeeded

History

  • 💚 Build #203 succeeded 1b8f03a994a9f88bce358553c7e0325d40c31c19
  • 💚 Build #202 succeeded 718e601ff3850ddf9a167f95bf7db3928c2441ec

cc @efd6

@efd6 efd6 marked this pull request as ready for review June 19, 2023 07:05
@efd6 efd6 requested a review from a team as a code owner June 19, 2023 07:05
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 19, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kgeller
kgeller approved these changes Jun 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 5ab0222 into elastic:main Jun 20, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_aironet - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=cisco_aironet

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_asa - 2.18.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_duo - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=cisco_duo

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_ftd - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_ise - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ise

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_meraki - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_nexus - 0.14.0 containing this change is available at https://epr.elastic.co/search?package=cisco_nexus

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_secure_email_gateway - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=cisco_secure_email_gateway

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_secure_endpoint - 2.15.0 containing this change is available at https://epr.elastic.co/search?package=cisco_secure_endpoint

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Package cisco_umbrella - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella

@agmic agmic mentioned this pull request Nov 15, 2023
Closed
@efd6 efd6 deleted the 6582-cisco branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgeller kgeller kgeller approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:cisco_aironet Cisco Aironet (Community supported) Integration:cisco_asa Cisco ASA Integration:cisco_duo Cisco Duo Integration:cisco_ftd Cisco FTD Integration:cisco_ise Cisco ISE Integration:cisco_meraki Cisco Meraki Integration:cisco_nexus Cisco Nexus Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:cisco_secure_endpoint Cisco Secure Endpoint Integration:cisco_umbrella Cisco Umbrella

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @kgeller @andrewkroh