Skip to content

Azure Logs - Bump up Kibana version to ensure better user experience with Lens#6515

Closed
tdancheva wants to merge 2 commits intoelastic:mainfrom
tdancheva:azure-logs-bump-up-kibana-version
Closed

Azure Logs - Bump up Kibana version to ensure better user experience with Lens#6515
tdancheva wants to merge 2 commits intoelastic:mainfrom
tdancheva:azure-logs-bump-up-kibana-version

Conversation

@tdancheva
Copy link
Copy Markdown
Contributor

@tdancheva tdancheva commented Jun 8, 2023

What does this PR do?

Bump up the Kibana version to ensure a better user experience with Lens i.e. metric panel titles do not render with 8.6.x for example.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tdancheva tdancheva added the enhancement New feature or request label Jun 8, 2023
@tdancheva tdancheva marked this pull request as ready for review June 8, 2023 08:42
@tdancheva tdancheva requested review from a team as code owners June 8, 2023 08:42
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tdancheva tdancheva force-pushed the azure-logs-bump-up-kibana-version branch from 62afd4f to 225ca8e Compare June 8, 2023 10:08
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 8, 2023

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-08T10:37:29.670+0000

  • Duration: 13 min 23 sec

Test stats 🧪

Test Results
Failed 1
Passed 72
Skipped 0
Total 73

Test errors 1

Expand to view the tests failures

pipeline test: test-platformlogs-invalid-raw.log – azure.platformlogs
    Expand to view the error details

     null 
    

    Expand to view the stacktrace

     test case failed: Expected results are different from actual ones: --- want
    +++ got
    @@ -5,25 +5,7 @@
                 "azure": {
                     "platformlogs": {
                         "category": "ApplicationGatewayAccessLog",
    -                    "event_category": "Administrative",
    -                    "operation_name": "ApplicationGatewayAccess",
    -                    "properties": {
    -                        "clientIP": "172.105.13.165",
    -                        "clientPort": 18234,
    -                        "host": "IP",
    -                        "httpMethod": "GET",
    -                        "httpStatus": 502,
    -                        "httpVersion": "HTTP/1.1",
    -                        "instanceId": "ApplicationGatewayRole_IN_1",
    -                        "originalHost": "IP",
    -                        "receivedBytes": 108,
    -                        "requestQuery": "X-AzureApplicationGateway-CACHE-HIT=0",
    -                        "requestUri": "/nmaplowercheck1602448229",
    -                        "sentBytes": 1636,
    -                        "sslEnabled": "off",
    -                        "timeTaken": 78,
    -                        "userAgent": "Mozilla/5.0"
    -                    }
    +                    "event_category": "Administrative"
                     },
                     "resource": {
                         "id": "/SUBSCRIPTIONS/SUBSCRIPTION/RESOURCEGROUPS/ET-AZURE-INTEGRATION-TESTING/PROVIDERS/MICROSOFT.NETWORK/APPLICATIONGATEWAYS/LANGERGATEWAY",
    @@ -36,12 +18,15 @@
                 "ecs": {
                     "version": "8.0.0"
                 },
    +            "error": {
    +                "message": "Received invalid json from the Azure Cloud platform. Unable to parse the source log message"
    +            },
                 "event": {
    -                "action": "ApplicationGatewayAccess",
                     "kind": "event",
                     "original": "{ \"resourceId\": \"/SUBSCRIPTIONS/SUBSCRIPTION/RESOURCEGROUPS/ET-AZURE-INTEGRATION-TESTING/PROVIDERS/MICROSOFT.NETWORK/APPLICATIONGATEWAYS/LANGERGATEWAY\", \"operationName\": \"ApplicationGatewayAccess\", \"time\": \"2020-10-11T20:30:59Z\", \"category\": \"ApplicationGatewayAccessLog\", \"properties\": {\"instanceId\":\"ApplicationGatewayRole_IN_1\",\"clientIP\":\"172.105.13.165\",\"clientPort\":18234,\"httpMethod\":\"GET\",\"requestUri\":\"/nmaplowercheck1602448229\",\"requestQuery\":\"X-AzureApplicationGateway-CACHE-HIT=0\",\"userAgent\":\"Mozilla/5.0\",\"httpStatus\":502,\"httpVersion\":\"HTTP/1.1\",\"receivedBytes\":108,\"sentBytes\":1636,\"timeTaken\":78,\"sslEnabled\":\"off\",\"host\":\"IP\",\"originalHost\":\"IP\"}},{ \"resourceId\": \"/SUBSCRIPTIONS/SUBSCRIPTION/RESOURCEGROUPS/ET-AZURE-INTEGRATION-TESTING/PROVIDERS/MICROSOFT.NETWORK/APPLICATIONGATEWAYS/LANGERGATEWAY\", \"operationName\": \"ApplicationGatewayAccess\", \"time\": \"2020-10-11T20:30:59Z\", \"category\": \"ApplicationGatewayAccessLog\", \"properties\": {\"instanceId\":\"ApplicationGatewayRole_IN_1\",\"clientIP\":\"172.105.13.165\",\"clientPort\":18706,\"httpMethod\":\"GET\",\"requestUri\":\"/evox/about\",\"requestQuery\":\"X-AzureApplicationGateway-CACHE-HIT=0\",\"userAgent\":\"Mozilla/5.0\",\"httpStatus\":502,\"httpVersion\":\"HTTP/1.1\",\"receivedBytes\":94,\"sentBytes\":1636,\"timeTaken\":62,\"sslEnabled\":\"off\",\"host\":\"IP\",\"originalHost\":\"IP\"}}]}"
                 },
                 "tags": [
    +                "preserve_original_event",
                     "preserve_original_event"
                 ]
             },
     
    

Steps errors 2

Expand to view the steps failures

Test integration: azure
  • Took 0 min 13 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 8, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -7.386
Classes 86.364% (19/22) 👎 -7.386
Methods 82.386% (145/176) 👎 -3.534
Lines 84.935% (2802/3299) 👎 -0.99
Conditionals 100.0% (0/0) 💚

@tdancheva tdancheva closed this Jun 8, 2023
@tdancheva tdancheva deleted the azure-logs-bump-up-kibana-version branch June 8, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants