Skip to content

Migrate "[Azure Logs] Alerts Overview" dashboard to Lens#6504

Merged
tdancheva merged 10 commits intoelastic:mainfrom
tdancheva:dashboard-alerts-overview
Jul 19, 2023
Merged

Migrate "[Azure Logs] Alerts Overview" dashboard to Lens#6504
tdancheva merged 10 commits intoelastic:mainfrom
tdancheva:dashboard-alerts-overview

Conversation

@tdancheva
Copy link
Copy Markdown
Contributor

@tdancheva tdancheva commented Jun 7, 2023

What does this PR do?

Migration of the "[Azure Logs] Alerts Overview" dashboard to Lens, remove global filters, and follow the latest dashboard design guidelines.

The Activity Logs API updates the category field when sending Alerts, not the event_category, so the dashboard was not functioning. I changed the filters to look at either of the values.

Screenshot 2023-06-08 at 09 48 33

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before it was not populated.

After:
AFTER

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-18T15:26:14.822+0000

  • Duration: 15 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👎 -4.545
Lines 85.003% (2817/3314) 👎 -12.469
Conditionals 100.0% (0/0) 💚

…board, API sends category:Alerts, not category_events:Alerts
@tdancheva tdancheva marked this pull request as ready for review June 8, 2023 07:50
@tdancheva tdancheva requested a review from a team as a code owner June 8, 2023 07:50
@tdancheva tdancheva added the enhancement New feature or request label Jun 8, 2023
@zmoog zmoog requested a review from a team June 8, 2023 09:39
Copy link
Copy Markdown

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, LGTM!

@botelastic
Copy link
Copy Markdown

botelastic bot commented Jul 14, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 14, 2023
@botelastic botelastic bot removed the Stalled label Jul 18, 2023
@tdancheva tdancheva merged commit 8809231 into elastic:main Jul 19, 2023
@tdancheva tdancheva deleted the dashboard-alerts-overview branch July 19, 2023 14:51
@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:azure Azure Logs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants