[AWS] Set dimension fields in Usage, ELB and DynamoDB data streams#6225
Merged
constanca-m merged 5 commits intoelastic:mainfrom May 23, 2023
Merged
[AWS] Set dimension fields in Usage, ELB and DynamoDB data streams#6225constanca-m merged 5 commits intoelastic:mainfrom
constanca-m merged 5 commits intoelastic:mainfrom
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
18 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
kaiyan-sheng
approved these changes
May 16, 2023
tetianakravchenko
approved these changes
May 17, 2023
Contributor
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set dimension fields for TSDB support.
Details
For all of them, account and region are always set as dimensions, as resources are unique within this scope.
Data stream DynamoDB:
TableNameandStreamLabelare unique per account and region, so they are used as identifiers.GlobalSecondaryIndexNameis unique per DynamoDB resource, and since we can have more than one, we have to set it as a dimension to avoid overwriting the documents.DelegatedOperationis associated with calls made to the table or index, and it is possible to have more than one at the same time, so it is set as dimension as well. A table can have more than oneReceivingRegion, so that label needs to be unique as well. Multipleverbscan act at the sametableat the same time, soverbalso needs to be set as dimension to avoid loosing data.OperationTypeandOperationare set as dimension for the same reason.Data stream ELB:
LoadBalancerNameis unique within the AWS account. A LoadBalancer can have more than oneTargetGroup, so we need to set that as dimension as well.AvailabilityZoneis set as dimension for the same reason.Data stream Usage: Each
Servicefield value is unique, and we can have differentResourcesacting on the same service at the same time, so it needs to be set as dimension to avoid overwriting.TypeandClassare set as dimensions for the same reason.Checklist
changelog.ymlfile.Screenshots
There was no change in the number of documents before and after enbaling TSDB in DynamoDB:
For usage and ELB data streams is not possible to compare it, since the data received is not regular. However, the number of documents did not seem to decrease after enabling TSDB and the variations seemed to remain constant (TSDB enabled at 13:20):
