windows: set host.os.type and host.os.family in forwarded events#6180
Merged
efd6 merged 1 commit intoelastic:mainfrom May 18, 2023
Merged
windows: set host.os.type and host.os.family in forwarded events#6180efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
rdner
reviewed
May 15, 2023
Member
There was a problem hiding this comment.
- Since both fields are basically hard-coded, why do we need them both?
- Does this field exist for Linux and Mac too?
Contributor
Author
There was a problem hiding this comment.
My understanding is that they are used in detection rules. Some rules will be based on family and some on name, it just happens that Windows was so good they named it twice.
Yes, these fields exist for other OSs, but they are not relevant here.
ebeahan
approved these changes
May 18, 2023
Member
ebeahan
left a comment
There was a problem hiding this comment.
LGTM after the changelog entry is updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set
host.os.typeandhost.os.familyto windows in forwarded events.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots