Skip to content

Enable Request tracer on System and Windows integrations#6163

Merged
bhapas merged 4 commits intoelastic:mainfrom
bhapas:diag-agent-data-plane
May 11, 2023
Merged

Enable Request tracer on System and Windows integrations#6163
bhapas merged 4 commits intoelastic:mainfrom
bhapas:diag-agent-data-plane

Conversation

@bhapas
Copy link
Copy Markdown
Contributor

@bhapas bhapas commented May 11, 2023 •
edited
Loading

What does this PR do?

This PR enables request tracer on integrations with httpjson input.

Sets the minimum Kibana version to 8.7.1

Enables the request tracer in system tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Reviewer's checklist

  • system
  • windows

Related

@bhapas bhapas force-pushed the diag-agent-data-plane branch from 1f385da to 4b3ec76 Compare May 11, 2023 11:15
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-11T16:39:16.268+0000

  • Duration: 16 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 274
Skipped 0
Total 274

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@bhapas bhapas mentioned this pull request May 11, 2023
Closed
4 tasks
@bhapas bhapas changed the title Diag agent data plane Enable Request tracer on System and Windows integrations May 11, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 91.667% (11/12) 👎 -8.333
Classes 91.667% (11/12) 👎 -8.333
Methods 72.941% (124/170) 👎 -23.903
Lines 95.058% (7925/8337) 👍 1.359
Conditionals 100.0% (0/0) 💚

@bhapas bhapas marked this pull request as ready for review May 11, 2023 11:34
@bhapas bhapas requested review from a team as code owners May 11, 2023 11:34
@bhapas bhapas requested review from cmacknz and leehinman May 11, 2023 11:34
@bhapas bhapas self-assigned this May 11, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@bhapas bhapas added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label May 11, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

leehinman
leehinman approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the changes.

One suggestion on the description field in manifest.yml, add where the logs will be written. As a user it can be frustrating to enable debugging but not know where the debugging info will appear.

@bhapas
Copy link
Copy Markdown
Contributor Author

bhapas commented May 11, 2023

One suggestion on the description field in manifest.yml, add where the logs will be written. As a user it can be frustrating to enable debugging but not know where the debugging info will appear.

@leehinman These logs are part of the agent diagnostics dump. May be that isn't obvious.

@bhapas bhapas merged commit e0d7e51 into elastic:main May 11, 2023
@bhapas bhapas deleted the diag-agent-data-plane branch May 11, 2023 16:56
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023

Package system - 1.28.0 containing this change is available at https://epr.elastic.co/search?package=system

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023

Package windows - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@leehinman leehinman leehinman approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@bhapas bhapas

Labels

enhancement New feature or request Integration:system System Integration:windows Windows Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bhapas @elasticmachine @andrewkroh @leehinman