Skip to content

[httpjson] Enable request tracer on obs service integrations#6160

Merged
bhapas merged 8 commits intoelastic:mainfrom
bhapas:diag-obs
May 16, 2023
Merged

[httpjson] Enable request tracer on obs service integrations#6160
bhapas merged 8 commits intoelastic:mainfrom
bhapas:diag-obs

Conversation

@bhapas
Copy link
Copy Markdown
Contributor

@bhapas bhapas commented May 11, 2023 •
edited
Loading

What does this PR do?

This PR enables request tracer on all OBS Service Integrations with httpjson input.

Sets the minimum Kibana version to 8.7.1

Enables the request tracer in system tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Reviewer's checklist

  • apache
  • ceph
  • citrix_adc
  • golang
  • nginx
  • php_fpm
  • salesforce

Related

@bhapas bhapas added the enhancement New feature or request label May 11, 2023
@bhapas bhapas self-assigned this May 11, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-12T07:53:16.217+0000

  • Duration: 17 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 174
Skipped 0
Total 174

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@bhapas bhapas changed the title [apache] Enable request tracer [httpjson] Enable request tracer on obs service integrations May 11, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (26/26) 💚
Files 86.667% (26/30) 👎 -10.35
Classes 86.667% (26/30) 👎 -10.35
Methods 91.379% (265/290) 👎 -0.309
Lines 92.41% (3811/4124) 👍 0.366
Conditionals 100.0% (0/0) 💚

@bhapas bhapas mentioned this pull request May 11, 2023
Closed
4 tasks
@bhapas bhapas marked this pull request as ready for review May 11, 2023 09:33
@bhapas bhapas requested a review from a team as a code owner May 11, 2023 09:33
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 11, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@bhapas bhapas added Team:Service-Integrations Label for the Observability Service Integrations team and removed Team:Security-External Integrations labels May 11, 2023
andrewkroh
andrewkroh approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No duplicate var definitions found.

shmsr
shmsr requested changes May 12, 2023
View reviewed changes
shmsr
shmsr requested changes May 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@bhapas bhapas requested a review from shmsr May 12, 2023 07:53
shmsr
shmsr approved these changes May 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it'd be great if someone else from my team also takes a look as I'm still new to integrations.

@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented May 12, 2023

@bhapas : What is criticality of this change ?
Since for couple of integrations we are jumping from 8.3 to 8.7 (big jump). We might have to evaluate that

@bhapas
Copy link
Copy Markdown
Contributor Author

bhapas commented May 12, 2023

@bhapas : What is criticality of this change ? Since for couple of integrations we are jumping from 8.3 to 8.7 (big jump). We might have to evaluate that

@ishleenk17 This change would enable the users of the integration be able to enable request-response tracing between the host and the agent. This would be helpful in debugging the issues as these logs are part of agent diagnostics.

Not sure about the big jump though... We are already on the 8.8 of stack and any new feature in beats shall only be on 8.7 (8.7.2)or above. What else do you think would cause an issue?

@bhapas bhapas merged commit ce78cfe into elastic:main May 16, 2023
@bhapas bhapas deleted the diag-obs branch May 16, 2023 09:23
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 16, 2023

Package apache - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=apache

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 16, 2023

Package ceph - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=ceph

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 16, 2023

Package citrix_adc - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=citrix_adc

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 16, 2023

Package golang - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=golang

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 16, 2023

Package nginx - 1.13.0-beta containing this change is available at https://epr.elastic.co/search?package=nginx

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 16, 2023

Package php_fpm - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 16, 2023

Package salesforce - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=salesforce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@shmsr shmsr shmsr approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees

@bhapas bhapas

Labels

enhancement New feature or request Integration:apache Apache HTTP Server Integration:ceph Ceph Integration:citrix_adc Citrix ADC Integration:golang Golang Integration:nginx Nginx Integration:php_fpm PHP-FPM Integration:salesforce Salesforce Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bhapas @elasticmachine @ishleenk17 @andrewkroh @shmsr