Skip to content

Nginx: Enable TSDB index mode for beta testing#6129

Merged
lalit-satapathy merged 2 commits intoelastic:mainfrom
lalit-satapathy:nginx_tsdb_beta_enable
May 10, 2023
Merged

Nginx: Enable TSDB index mode for beta testing#6129
lalit-satapathy merged 2 commits intoelastic:mainfrom
lalit-satapathy:nginx_tsdb_beta_enable

Conversation

@lalit-satapathy
Copy link
Contributor

@lalit-satapathy lalit-satapathy commented May 9, 2023

What does this PR do?

This PR enables beta testing of Nginx package for TSDB. The package has been already migrated with dimension and metric type mapping. Here it enables index_mode: "time_series" for nginx stubstatus data stream and also upgrades stack version to 8.8.0.

Package version made -beta to avoid accidental use from other users.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Load 8.8.0+ stack
  • Run nginx server.
  • Load latest package locally/cloud and follow detailed testing plan.

Related issues

Screenshots

Screenshot 2023-05-09 at 6 37 13 PM

@lalit-satapathy lalit-satapathy added the enhancement New feature or request label May 9, 2023
@lalit-satapathy lalit-satapathy self-assigned this May 9, 2023
@lalit-satapathy lalit-satapathy changed the title Enable TSDB index mode for beta testing Nginx: Enable TSDB index mode for beta testing May 9, 2023
@elasticmachine
Copy link

elasticmachine commented May 9, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-09T13:44:38.007+0000

  • Duration: 19 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👍
Classes 50.0% (2/4) 👍
Methods 69.231% (27/39) 👍
Lines 70.37% (228/324) 👍
Conditionals 100.0% (0/0) 💚

@lalit-satapathy lalit-satapathy marked this pull request as ready for review May 9, 2023 14:03
@lalit-satapathy lalit-satapathy requested a review from a team as a code owner May 9, 2023 14:03
agithomas
agithomas reviewed May 9, 2023
View reviewed changes
agithomas
agithomas approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lalit-satapathy
Copy link
Contributor Author

lalit-satapathy commented May 10, 2023

FYI: @ruflin @andresrc @mlunadia

ruflin
ruflin approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My understanding is for a user to get this change they have to be on 8.8 and have the beta toggle enabled:

Screenshot 2023-05-10 at 09 49 14

@lalit-satapathy
Copy link
Contributor Author

lalit-satapathy commented May 10, 2023

My understanding is for a user to get this change they have to be on 8.8 and have the beta toggle enabled:

Yes for both.

@lalit-satapathy lalit-satapathy merged commit 873f6ce into elastic:main May 10, 2023
@elasticmachine
Copy link

elasticmachine commented May 10, 2023

Package nginx - 1.12.0-beta containing this change is available at https://epr.elastic.co/search?package=nginx

@ruflin
Copy link
Contributor

ruflin commented May 10, 2023

@kpollich Having now this package available should also make it easier to test the rollback features.

@lalit-satapathy I would be nice to have this for the system package for 1-3 dataset. The reason is because with system it is easy to gather data.

@lalit-satapathy
Copy link
Contributor Author

lalit-satapathy commented May 10, 2023

@lalit-satapathy I would be nice to have this for the system package for 1-3 dataset. The reason is because with system it is easy to gather data.

@tetianakravchenko to explore enabling TSDB for few datasets in system package first.

@agithomas agithomas mentioned this pull request May 10, 2023
Closed
@lalit-satapathy lalit-satapathy mentioned this pull request May 15, 2023
Merged
4 tasks
@lalit-satapathy lalit-satapathy mentioned this pull request May 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruflin ruflin ruflin approved these changes

@tetianakravchenko tetianakravchenko tetianakravchenko approved these changes

@agithomas agithomas agithomas approved these changes

Assignees

@lalit-satapathy lalit-satapathy

Labels

enhancement New feature or request Integration:nginx Nginx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lalit-satapathy @elasticmachine @ruflin @tetianakravchenko @agithomas @andrewkroh