Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
| @@ -1,15 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Thanks for removing this! For context, Fleet installs and attaches two tags to Kibana assets when a package is installed: Managed and {package name}. This is to differentiate managed integration assets from normal dashboards etc because the behavior is different (they get overridden on package upgrades).
The other tag with ID system-fleet-pkg-system-default should also be removed. Did elastic-package export dashboards not strip this one? @mrodm, shouldn't the changes in elastic/elastic-package#1206 have caught this pattern as well?
There was a problem hiding this comment.
It didn't strip either of them; I had to manually remove the tag. I can do that for the other as well.
There was a problem hiding this comment.
What version of elastic-package was used to export that dashboard?
That was released in version v0.78.0 of elastic-package. Could it be that it was exported with an older version ?
Just tested to export that dashboard with elastic-package v0.78.0 and it removes the tags from the dashboard:
@@ -883,16 +883,6 @@
"id": "system-eb0039f0-fa7f-11e6-a1df-a78bd7504d38",
"name": "edc0a4ad-a2f9-4ae8-93ca-cfd7d0ed40fe:search_0",
"type": "search"
- },
- {
- "id": "system-fleet-managed-default",
- "name": "tag-ref-fleet-managed-default",
- "type": "tag"
- },
- {
- "id": "system-fleet-pkg-system-default",
- "name": "tag-ref-fleet-pkg-system-default",
- "type": "tag"
}Command used: elastic-package export dashboard --id system-0d3f2380-fa78-11e6-ae9b-81e5311e8cab
Just a note, elastic-package export dashboard does not remove the tags files (kibana/tags/*). Those tags could be used by other dashboards and it could break it.
There was a problem hiding this comment.
Command used:
elastic-package export dashboard --id system-0d3f2380-fa78-11e6-ae9b-81e5311e8cabJust a note,
elastic-package export dashboarddoes not remove the tags files (kibana/tags/*). Those tags could be used by other dashboards and it could break it.
This was the issue. I did not find instruction indicating otherwise, so I used the standard export.
|
Package system - 1.27.1 containing this change is available at https://epr.elastic.co/search?package=system |
What does this PR do?
Removes managed tag.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots