[AWS][Lambda] Add dimension fields for TSDB support#5973
[AWS][Lambda] Add dimension fields for TSDB support#5973constanca-m merged 3 commits intoelastic:mainfrom
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
| description: Lambda function name. | ||
| - name: Resource | ||
| type: keyword | ||
| dimension: true |
There was a problem hiding this comment.
what is a meaning of the Resource field? From the issue description I got an impression that name of function and version uniquely identify the function
There was a problem hiding this comment.
For example, without setting Resource as dimension, these 2 documents will be overwriting each other:
There was a problem hiding this comment.
hmm, what is the difference between those documents?
There was a problem hiding this comment.
Good question. The only difference from comparing these two documents is than one has the dimension resource and the other has not, but even the values for the metrics are exactly the same @tetianakravchenko I am not sure if I should let be overwritten then or how to make sure that the one with the resource set will be the final document.
There was a problem hiding this comment.
@elastic/obs-cloud-monitoring is it an expected behavior that there are 2 documents with the same data?
@constanca-m so far it seems for me that generic pattern for aws package datasreams is to add all fields that are part of dimensions.* object, so I would keep it, I think we shouldn't make a decision on what should be overwritten
|
Package aws - 1.36.7 containing this change is available at https://epr.elastic.co/search?package=aws |
What does this PR do?
Add dimension fields to Lambda datastream.
Details
The lambda function name is unique per region within an account. Since the lambda function can have different versions, we need to make that a dimension as well. As the version affects the resource name, this will be our last dimension.
There was not a change in the number of documents after enabling TSDB:
Tested with one account, one lambda function with two different versions.
Checklist
changelog.ymlfile.How to test this PR locally
Refer to #5970
Related issues