Skip to content

Enhancements dashboards azure#5954

Merged
tdancheva merged 7 commits intoelastic:mainfrom
tdancheva:enhancements-dashboards-azure
May 23, 2023
Merged

Enhancements dashboards azure#5954
tdancheva merged 7 commits intoelastic:mainfrom
tdancheva:enhancements-dashboards-azure

Conversation

@tdancheva
Copy link
Copy Markdown
Contributor

@tdancheva tdancheva commented Apr 21, 2023 •
edited
Loading

What does this PR do?

List of changes - Dashboard enhancements in the Azure package implementation:

  1. Inlining the visualizations
  2. Set up global filters on the relevant dataset used in the dashboard
  3. Replace deprecated input control and reorganize the panels if necessary
  4. Bumping up the version of the search panels

Azure contains:

  • Generic EventHub
  • Azure Active Directory Logs ( Sign-in, Audit, Identity Protection, Provisioning)
  • Azure Activity Logs
  • Azure Platform Logs
  • Azure Spring Cloud logs
  • Azure Firewall logs
  • Azure Application Gateway Logs

List of enhanced dashboards:

  • [Logs Azure] Azure Spring Cloud logs Overview
  • [Logs Azure] Azure Spring Cloud Logs System Logs
  • [Logs Azure] Alerts Overview
  • [Logs Azure] User Activity
  • [Logs Azure] Cloud Overview
  • [Logs Azure] Firewall DNS Proxy Log
  • [Logs Azure] Firewall Application Rule Log
  • [Logs Azure] Firewall Network NAT Rule Log
  • [Logs Azure] Azure AD Provisioning Logs
  • [Logs Azure] Azure AD Identity Protection
  • [Logs Azure] Azure Spring Cloud Logs Application Cloud Logs
  • [Logs Azure] Firewall Overview

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Check to validate changes:

  1. Check folder structure and panels are unbroken
  2. Check if pre-filters are applied below the search query bar
  3. Validate that the new input controls have the same functionality as the deprecated ones

Related issues

Screenshots

Example dashboard to illustrate changes - [Logs Azure] User Activity

Before:
before

After:

after

@tdancheva tdancheva added the enhancement New feature or request label Apr 21, 2023
@tdancheva tdancheva self-assigned this Apr 21, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-15T15:45:38.718+0000

  • Duration: 14 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👎 -12.5
Lines 84.935% (2802/3299) 👎 -2.299
Conditionals 100.0% (0/0) 💚

@tdancheva tdancheva marked this pull request as ready for review April 21, 2023 12:24
@tdancheva tdancheva requested a review from a team as a code owner April 21, 2023 12:24
@tdancheva tdancheva added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Apr 21, 2023
@tdancheva
Copy link
Copy Markdown
Contributor Author

tdancheva commented May 3, 2023

Just a comment on this PR, this is the initial refactoring with all of the smaller changes to all of the dashboards in the azure package grouped together. My reasoning is that it can be checked quite fast given the almost identical changes to all of the dashboards. The migration to lens is ready for all of the dashboards as well and will go one PR/dashboard to facilitate validation once this PR Is approved given that this PR is the basis for the rest of the changes. Let me know if you think otherwise!

@kaiyan-sheng kaiyan-sheng self-requested a review May 16, 2023 21:44
@tdancheva tdancheva merged commit 098cd28 into elastic:main May 23, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 24, 2023

Package azure - 1.5.14 containing this change is available at https://epr.elastic.co/search?package=azure

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 19, 2023

Package azure - 1.5.28 containing this change is available at https://epr.elastic.co/search?package=azure

@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tdancheva tdancheva

Labels

enhancement New feature or request Integration:azure Azure Logs Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tdancheva @elasticmachine @kaiyan-sheng @andrewkroh