Skip to content

Add system tests to Juniper#588

Merged
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:feature/juniper/system-tests
Feb 1, 2021
Merged

Add system tests to Juniper#588
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:feature/juniper/system-tests

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Jan 30, 2021

What does this PR do?

Add system tests to Juniper.

junos:

  • Add system tests for logfile, udp, tcp inputs.
  • Fix input name in manifest (s/file/logfile).
  • No pipeline tests b/c most processing is in beats (rsa2elk).

netscreen:

  • Add system tests for logfile, udp, tcp inputs.
  • Rename stream template from log.yml.hbs to logfile.yml.hbs.
  • No pipeline tests b/c most processing is in beats (rsa2elk).

srx:

  • Add system tests for logfile, udp, tcp inputs.
  • Fix input name (s/file/logfile/).
  • Rename stream template from log.yml.hbs to logfile.yml.hbs.
  • Add missing field definitions:
    • input.type
    • log.offset
    • log.source.address

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

Related issues

Screenshots

--- Test results for package: juniper - START ---
╭─────────┬─────────────┬───────────┬────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME                                              │ RESULT │ TIME ELAPSED │
├─────────┼─────────────┼───────────┼────────────────────────────────────────────────────────┼────────┼──────────────┤
│ juniper │ junos       │ asset     │ index_template logs-juniper.junos is loaded            │ PASS   │ 7.760283715s │
│ juniper │ junos       │ asset     │ ingest_pipeline logs-juniper.junos-0.4.5 is loaded     │ PASS   │      2.498µs │
│ juniper │ netscreen   │ asset     │ index_template logs-juniper.netscreen is loaded        │ PASS   │        498ns │
│ juniper │ netscreen   │ asset     │ ingest_pipeline logs-juniper.netscreen-0.4.5 is loaded │ PASS   │        412ns │
│ juniper │ srx         │ asset     │ index_template logs-juniper.srx is loaded              │ PASS   │        437ns │
│ juniper │ srx         │ asset     │ ingest_pipeline logs-juniper.srx-0.4.5 is loaded       │ PASS   │        459ns │
╰─────────┴─────────────┴───────────┴────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: juniper - END   ---
Done
Run pipeline tests for the package
--- Test results for package: juniper - START ---
╭─────────┬─────────────┬───────────┬───────────────────┬────────┬──────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME         │ RESULT │ TIME ELAPSED │
├─────────┼─────────────┼───────────┼───────────────────┼────────┼──────────────┤
│ juniper │ srx         │ pipeline  │ test-atp.log      │ PASS   │  55.773481ms │
│ juniper │ srx         │ pipeline  │ test-flow.log     │ PASS   │ 240.075154ms │
│ juniper │ srx         │ pipeline  │ test-idp.log      │ PASS   │   51.43499ms │
│ juniper │ srx         │ pipeline  │ test-ids.log      │ PASS   │  57.472657ms │
│ juniper │ srx         │ pipeline  │ test-secintel.log │ PASS   │   14.99661ms │
│ juniper │ srx         │ pipeline  │ test-utm.log      │ PASS   │   81.51712ms │
╰─────────┴─────────────┴───────────┴───────────────────┴────────┴──────────────╯
--- Test results for package: juniper - END   ---
Done
Run system tests for the package
--- Test results for package: juniper - START ---
╭─────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├─────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ juniper │ junos       │ system    │ logfile   │ PASS   │ 39.602637111s │
│ juniper │ junos       │ system    │ tcp       │ PASS   │ 44.540703986s │
│ juniper │ junos       │ system    │ udp       │ PASS   │ 43.431253466s │
│ juniper │ netscreen   │ system    │ logfile   │ PASS   │ 36.399498052s │
│ juniper │ netscreen   │ system    │ tcp       │ PASS   │  44.16563128s │
│ juniper │ netscreen   │ system    │ udp       │ PASS   │  39.99572436s │
│ juniper │ srx         │ system    │ logfile   │ PASS   │ 17.172948389s │
│ juniper │ srx         │ system    │ tcp       │ PASS   │ 25.731103445s │
│ juniper │ srx         │ system    │ udp       │ PASS   │ 26.793249292s │
╰─────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: juniper - END   ---

@andrewkroh
Add system tests to Juniper
c6eb5db 
junos:

- Add system tests for logfile, udp, tcp inputs.
- Fix input name in manifest (s/file/logfile).
- No pipeline tests b/c most processing is in beats (rsa2elk).

netscreen:

- Add system tests for logfile, udp, tcp inputs.
- Rename stream template from log.yml.hbs to logfile.yml.hbs.
- No pipeline tests b/c most processing is in beats (rsa2elk).

srx:

- Add system tests for logfile, udp, tcp inputs.
- Fix input name (s/file/logfile/).
- Rename stream template from log.yml.hbs to logfile.yml.hbs.
- Add missing field definitions:
  - input.type
  - log.offset
  - log.source.address
@andrewkroh andrewkroh mentioned this pull request Jan 30, 2021
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #588 opened

    • Start Time: 2021-01-30T16:14:36.813+0000

  • Duration: 19 min 42 sec

  • Commit: c6eb5db

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 31, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh merged commit 28ad7c0 into elastic:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adriansr adriansr adriansr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewkroh @elasticmachine @adriansr @andresrc