Skip to content

Add system tests for Fortinet Firewall udp/tcp inputs#585

Merged
andrewkroh merged 2 commits intoelastic:masterfrom
andrewkroh:feature/fortinet/firewall-udp-tcp-system-test
Feb 1, 2021
Merged

Add system tests for Fortinet Firewall udp/tcp inputs#585
andrewkroh merged 2 commits intoelastic:masterfrom
andrewkroh:feature/fortinet/firewall-udp-tcp-system-test

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Jan 29, 2021 •
edited
Loading

What does this PR do?

Add system tests for Fortinet udp/tcp inputs.

In Fortinet/Firewall these changes were needed:

  • Add log.source.address to fields.
  • Add ecs.version to fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

Related issues

Screenshots

--- Test results for package: fortinet - START ---
╭──────────┬────────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE  │ DATA STREAM    │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├──────────┼────────────────┼───────────┼───────────┼────────┼───────────────┤
│ fortinet │ clientendpoint │ system    │ logfile   │ PASS   │ 40.103033895s │
│ fortinet │ clientendpoint │ system    │ tcp       │ PASS   │  52.94370252s │
│ fortinet │ clientendpoint │ system    │ udp       │ PASS   │ 47.043500055s │
│ fortinet │ firewall       │ system    │ logfile   │ PASS   │ 22.015932898s │
│ fortinet │ firewall       │ system    │ tcp       │ PASS   │ 35.457783979s │
│ fortinet │ firewall       │ system    │ udp       │ PASS   │ 30.875337455s │
│ fortinet │ fortimail      │ system    │ logfile   │ PASS   │ 37.390398624s │
│ fortinet │ fortimail      │ system    │ tcp       │ PASS   │ 45.167548946s │
│ fortinet │ fortimail      │ system    │ udp       │ PASS   │ 45.672010246s │
│ fortinet │ fortimanager   │ system    │ logfile   │ PASS   │   41.1158412s │
│ fortinet │ fortimanager   │ system    │ tcp       │ PASS   │ 49.251895257s │
│ fortinet │ fortimanager   │ system    │ udp       │ PASS   │ 57.573378435s │
╰──────────┴────────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: fortinet - END   ---

@andrewkroh
Add system tests for Fortinet Firewall udp/tcp inputs
1757c9d 
Add log.source.address to fields.
Add ecs.version to fields.
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 29, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh mentioned this pull request Jan 29, 2021
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 29, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #585 updated

    • Start Time: 2021-01-29T22:21:59.786+0000

  • Duration: 31 min 19 sec

  • Commit: 134a4af

Test stats 🧪

Test Results
Failed 0
Passed 1526
Skipped 0
Total 1526

@andrewkroh andrewkroh merged commit 17e28c4 into elastic:master Feb 1, 2021
@adriansr adriansr mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adriansr adriansr adriansr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewkroh @elasticmachine @adriansr