Skip to content

[O11y][Oracle] Migrate System Statistics dashboard visualizations to kibana 8.6.0#5815

Merged
kush-elastic merged 5 commits intoelastic:mainfrom
chavdaharnish:lens_migration-oracle-system_statistics
Apr 13, 2023
Merged

[O11y][Oracle] Migrate System Statistics dashboard visualizations to kibana 8.6.0#5815
kush-elastic merged 5 commits intoelastic:mainfrom
chavdaharnish:lens_migration-oracle-system_statistics

Conversation

@harnish-crest-data
Copy link
Copy Markdown
Contributor

@harnish-crest-data harnish-crest-data commented Apr 6, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Oracle integration package

  • Statistics for Oracle Lens migration:

Oracle Dashboards Before Migration   After Migration
  Lens Visualization Lens Visualization
[Metrics Oracle] System Statistics 0 8 8 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.6.0.

Related issues

@harnish-crest-data harnish-crest-data marked this pull request as ready for review April 6, 2023 16:44
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner April 6, 2023 16:44
@kush-elastic kush-elastic added enhancement New feature or request Integration:oracle Oracle v8.6.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Apr 6, 2023
kush-elastic
kush-elastic approved these changes Apr 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-crest-data harnish-crest-data mentioned this pull request Apr 6, 2023
Closed
10 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 6, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T08:23:47.106+0000

  • Duration: 29 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 6, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚
Lines 94.318% (249/264) ❕
Conditionals 100.0% (0/0) 💚

agithomas
agithomas reviewed Apr 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing lot many negative values in the screenshot. Please review and correct. Encourage to use oracle docker or oracle instance to generate the values

@harnish-crest-data
Copy link
Copy Markdown
Contributor Author

harnish-crest-data commented Apr 11, 2023

I am seeing lot many negative values in the screenshot. Please review and correct. Encourage to use oracle docker or oracle instance to generate the values

@agithomas, We have tried pulling the docker image which is mentioned in the integration package, but we don't have an access to pull the image. Could you please provide us an access so that we can setup the oracle and move forward. Please refer screenshot.

image

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Apr 11, 2023

I am seeing lot many negative values in the screenshot. Please review and correct. Encourage to use oracle docker or oracle instance to generate the values

@agithomas, We have tried pulling the docker image which is mentioned in the integration package, but we don't have an access to pull the image. Could you please provide us an access so that we can setup the oracle and move forward. Please refer screenshot.

image

Please login to docker.elastic.co before the pull.

@harnish-crest-data
Copy link
Copy Markdown
Contributor Author

harnish-crest-data commented Apr 11, 2023

@agithomas Used oracle docker to generate the values and updated the screenshot. Thanks!

agithomas
agithomas reviewed Apr 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parse time is negative. Please check.

@harnish-crest-data
Copy link
Copy Markdown
Contributor Author

harnish-crest-data commented Apr 13, 2023

Parse time is negative. Please check.

We have used the live instance. Now what happening is the parse time chart is using the differences aggregation. So what difference exactly do is, if the value is getting lesser than the previous value, the difference would be shown as negative in chart. Also this is the same behavior in the TSVB chart.

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Apr 13, 2023

Parse time is negative. Please check.

We have used the live instance. Now what happening is the parse time chart is using the differences aggregation. So what difference exactly do is, if the value is getting lesser than the previous value, the difference would be shown as negative in chart. Also this is the same behavior in the TSVB chart.

Got it. The current one looks good.

agithomas
agithomas approved these changes Apr 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 13, 2023
Closed
7 tasks
@harnish-crest-data
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
b6c086e 
…into lens_migration-oracle-system_statistics

Conflicts:
	packages/oracle/changelog.yml
	packages/oracle/manifest.yml
@kush-elastic kush-elastic merged commit 30e1bb8 into elastic:main Apr 13, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Nov 6, 2023
Closed
10 tasks
@kush-elastic kush-elastic mentioned this pull request Nov 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

enhancement New feature or request Integration:oracle Oracle Team:Service-Integrations Label for the Observability Service Integrations team v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harnish-crest-data @elasticmachine @agithomas @kush-elastic