Skip to content

[O11y][Vsphere] Migrate VMs Overview dashboard visualizations to lens in kibana 8.7.0 #5811

Merged
kush-elastic merged 4 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-vsphere-vm-overview-8.7.0
Apr 10, 2023
Merged

[O11y][Vsphere] Migrate VMs Overview dashboard visualizations to lens in kibana 8.7.0 #5811
kush-elastic merged 4 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-vsphere-vm-overview-8.7.0

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 6, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Vsphere integration package

  • Statistics for Vsphere VMs Overview Lens migration:

VSphere dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics VSphere] VMs overview 0 5 5 0
  0 5 5 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.0 itself.

Related issues

Note: Screenshot of before migration dashboard is not synced with Kibana files. Please find below screenshot to compare the migrated visualizations.

Metrics VSphere VMs overview (1)

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 6, 2023 12:04
@rajvi-patel-22 rajvi-patel-22 changed the title Migrate VMs Overview dashboard visualizations to lens [O11y][Vsphere] Migrate VMs Overview dashboard visualizations to lens in kibana 8.7.0 Apr 6, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 6, 2023
Closed
6 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:vsphere VMware vSphere v8.7.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Apr 6, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 6, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-10T05:43:42.157+0000

  • Duration: 17 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 6, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (18/18) 💚
Lines 89.13% (41/46) 👍
Conditionals 100.0% (0/0) 💚

agithomas
agithomas reviewed Apr 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The Memory value is represented in Human readable format in Old vis but not in New Vis.
    Can this be addressed. If not, i would recommend keeping the old vis
  2. What is the default sort order followed in the table?

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Apr 6, 2023

  1. The Memory value is represented in Human readable format in Old vis but not in New Vis.
    Can this be addressed. If not, i would recommend keeping the old vis
  2. What is the default sort order followed in the table?

@agithomas ,

  1. I have mentioned in the PR description that Kibana files and dashboards are not synced and also uploaded the before migration screenshot. In that the Memory value is not represented in Human readable format.
  2. Sorting orders are as below:
  • Name: Descending order by count
    image
  • Used CPU: Descending order by Maximum of vsphere.virtualmachine.cpu.used.mhz
    image
  • Total RAM: Descending order by Maximum of vsphere.virtualmachine.memory.total.guest.bytes
    image
  • Networks: Descending order by count
    image

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Apr 6, 2023

Is it possible to make the changes in the new layout, so that it appears more human readable (representing in MB/ GB) ?

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Apr 6, 2023

Is it possible to make the changes in the new layout, so that it appears more human readable (representing in MB/ GB) ?

Yes @agithomas, It is possible. I'll update the PR.

@rajvi-patel-22 rajvi-patel-22 requested a review from agithomas April 7, 2023 10:35
@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Apr 7, 2023

Is it possible to make the changes in the new layout, so that it appears more human readable (representing in MB/ GB) ?

@agithomas, I have updated the PR with mentioned changes.

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 7, 2023
Closed
1 task
agithomas
agithomas approved these changes Apr 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit d9eecf9 into elastic:main Apr 10, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 10, 2023

Package vsphere - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=vsphere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

+1 more reviewer

@milan-elastic milan-elastic milan-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

enhancement New feature or request Integration:vsphere VMware vSphere Team:Service-Integrations Label for the Observability Service Integrations team v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rajvi-patel-22 @elasticmachine @agithomas @milan-elastic @kush-elastic