Skip to content

Add tests to Cisco package#578

Merged
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:feature/cisco/system-tests
Jan 29, 2021
Merged

Add tests to Cisco package#578
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:feature/cisco/system-tests

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Jan 29, 2021 •
edited
Loading

What does this PR do?

Add ASA test for udp and logfile

  • Add a few missing field definitions.
  • Convert network.iana_number and event.code to strings (b/c they are keyword).

Add Cisco FTD system tests

  • Sync ASA pipeline with FTD (they are the same)
  • Update pipeline to use ECS log.syslog fields.
  • Add beats syslog input fields

Add system test for Cisco Meraki
Add system test for Cisco Nexus NX-OS

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Related issues

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 29, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #578 updated

    • Start Time: 2021-01-29T19:15:03.757+0000

  • Duration: 27 min 39 sec

  • Commit: 3dc059a

Test stats 🧪

Test Results
Failed 0
Passed 1514
Skipped 0
Total 1514

@andrewkroh
Add tests to Cisco package
3dc059a 
Add ASA test for udp and logfile

    Add a few missing field definitions.
    Convert network.iana_number and event.code to strings (b/c they are keyword).

Add Cisco FTD system tests

    Update pipeline to use ECS log.syslog fields.
    Add beats syslog input fields

Add system test for Cisco Meraki
Add system test for Cisco Nexus NX-OS
@andrewkroh andrewkroh marked this pull request as ready for review January 29, 2021 19:40
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 29, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh mentioned this pull request Jan 29, 2021
Closed
@andrewkroh andrewkroh merged commit b05c399 into elastic:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leehinman leehinman leehinman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewkroh @elasticmachine @leehinman @andresrc