Skip to content

[O11y][Oracle] Migrate Sysmetrics dashboard visualizations to lens in kibana 8.6.0#5757

Merged
kush-elastic merged 2 commits intoelastic:mainfrom
chavdaharnish:lens_migration-oracle-sysmetrics
Apr 13, 2023
Merged

[O11y][Oracle] Migrate Sysmetrics dashboard visualizations to lens in kibana 8.6.0#5757
kush-elastic merged 2 commits intoelastic:mainfrom
chavdaharnish:lens_migration-oracle-sysmetrics

Conversation

@harnish-crest-data
Copy link
Copy Markdown
Contributor

@harnish-crest-data harnish-crest-data commented Mar 30, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Oracle integration package

  • Statistics for Oracle Lens migration:

Oracle Dashboards Before Migration   After Migration
  Lens Visualization Lens Visualization
[Metrics Oracle] Sysmetrics 0 15 15 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.6.0.

Related issues

Note: - Previously the sysmetric dashboard divided into two screenshot. We have provided whole dashboard in one screenshot. Hence we have removed entry for second sysmetric dashboard screenshot from manifest.yml file

@harnish-crest-data harnish-crest-data marked this pull request as ready for review March 30, 2023 16:52
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner March 30, 2023 16:52
@harnish-crest-data harnish-crest-data mentioned this pull request Mar 30, 2023
Closed
10 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:oracle Oracle Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 30, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T16:52:34.438+0000

  • Duration: 30 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚
Lines 94.318% (249/264) 👎 -2.279
Conditionals 100.0% (0/0) 💚

@milan-elastic
Copy link
Copy Markdown
Contributor

milan-elastic commented Mar 30, 2023

Thanks, @harnish-elastic! Looks good, Approved!

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 31, 2023

Please explain the reason for kibana version change.

@kush-elastic
Copy link
Copy Markdown
Contributor

kush-elastic commented Mar 31, 2023

Please explain the reason for kibana version change.

We have already provided the reason behind why we are migrating to Kibana version 8.6.0 in the issue itself. The reason behind why we have mentioned there is that the dashboard (System Statistics) which lets us use kibana 8.6.0 is different from this PR.

agithomas
agithomas approved these changes Apr 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 1b70c59 into elastic:main Apr 13, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Nov 6, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

enhancement New feature or request Integration:oracle Oracle Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harnish-crest-data @elasticmachine @milan-elastic @agithomas @kush-elastic