Skip to content

[O11y][PostgreSQL] Lens migration for Database Overview visualizations to Kibana version 8.4.0#5748

Merged
kush-elastic merged 5 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-postgresql-database-overview-8.4.0
Apr 6, 2023
Merged

[O11y][PostgreSQL] Lens migration for Database Overview visualizations to Kibana version 8.4.0#5748
kush-elastic merged 5 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-postgresql-database-overview-8.4.0

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 30, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for PostgreSQL integration package

  • Statistics for PostgreSQL Lens migration:

PostgreSQL Dashboards  Before Migration   After Migration      
  Lens Visualization Lens Visualization New control panel
[Metrics PostgreSQL] Database Overview 0 10 9 0 1
  0 10 9 0 1

Note: One visualization is migrated to new input controls.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 30, 2023 12:40
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T15:40:40.165+0000

  • Duration: 17 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 44
Skipped 0
Total 44

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 30, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 93.333% (28/30) 👍 60.0
Lines 97.041% (164/169) 👎 -2.959
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 30, 2023
Closed
7 tasks
@kush-elastic kush-elastic self-requested a review March 31, 2023 06:30
kush-elastic
kush-elastic approved these changes Mar 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic added enhancement New feature or request Integration:postgresql PostgreSQL v8.4.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Apr 3, 2023
agithomas
agithomas reviewed Apr 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the Y-axis unit for these two panels ? it is not clear - if the Y axis shows count or a percentage?

image

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Apr 3, 2023

Can you please update the Y-axis unit for these two panels ? it is not clear - if the Y axis shows count or a percentage?

@agithomas, Please find below aggregation which is applied to the Shared block cache stats panel. We are not sure which unit should we put here. Can you please help us with this? Same functions are also used in the Local block cache stat panel.

image

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Apr 5, 2023

Can you please update the Y-axis unit for these two panels ? it is not clear - if the Y axis shows count or a percentage?

@agithomas, Please find below aggregation which is applied to the Shared block cache stats panel. We are not sure which unit should we put here. Can you please help us with this? Same functions are also used in the Local block cache stat panel.

image

Count can be considered here.

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 5, 2023
Closed
1 task
@rajvi-patel-22 rajvi-patel-22 requested a review from agithomas April 6, 2023 09:50
@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Apr 6, 2023

Can you please update the Y-axis unit for these two panels ? it is not clear - if the Y axis shows count or a percentage?

@agithomas, I have updated the PR as per your suggestion and added Y-axis label to the Local and shared block cache stats panels.

agithomas
agithomas approved these changes Apr 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22
Merge branch 'main' of github.com:rajvi-elastic/integrations into len…
4958f35 
…s_migration-postgresql-database-overview-8.4.0
@kush-elastic kush-elastic merged commit 524d606 into elastic:main Apr 6, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 6, 2023

Package postgresql - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=postgresql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request Integration:postgresql PostgreSQL Team:Service-Integrations Label for the Observability Service Integrations team v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajvi-patel-22 @elasticmachine @agithomas @kush-elastic