Skip to content

[O11y][Cassandra] Migrate System Log dashboard visualizations to lens in kibana 8.3.0#5715

Merged
kush-elastic merged 3 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-cassandra-logs-8.3.0
Apr 6, 2023
Merged

[O11y][Cassandra] Migrate System Log dashboard visualizations to lens in kibana 8.3.0#5715
kush-elastic merged 3 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-cassandra-logs-8.3.0

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 28, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Cassandra integration package

  • Statistics for Cassandra Lens migration:

  Before Migration   After Migration    
  Lens Visualization Lens Visualization New Control Panel
[Logs Cassandra] System Logs 0 3 1 1 (Markdown) 1
  0 3 1 1 (Markdown) 1

Note:

  • 1 visualization is migrated to new control panels.
  • 1 visualization is markdown which can not be migrated to the lens.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 28, 2023 12:52
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 28, 2023
Closed
6 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T06:31:54.940+0000

  • Duration: 16 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 33.333
Classes 100.0% (1/1) 💚 33.333
Methods 100.0% (13/13) 💚 20.339
Lines 91.228% (52/57) 👍 4.177
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic added enhancement New feature or request Integration:cassandra Cassandra v8.3.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 28, 2023
@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 29, 2023

@rajvi-elastic , can you please re-visit the table summary at the beginning of the PR.
The counts before and after migration are not matching. Also, the linked issue is tagged as having a workaround.

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Mar 29, 2023

@rajvi-elastic , can you please re-visit the table summary at the beginning of the PR. The counts before and after migration are not matching. Also, the linked issue is tagged as having a workaround.

@agithomas, I have updated the summary table and added one more column for the new control panel to avoid confusion.

@muthu-mps
Copy link
Copy Markdown
Contributor

muthu-mps commented Mar 30, 2023

Please update the PR description which is currently mentioning Redis Enterprise.

@kush-elastic kush-elastic self-requested a review March 30, 2023 06:49
kush-elastic
kush-elastic approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic requested a review from muthu-mps April 3, 2023 11:03
@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Apr 5, 2023

Please update the PR description which is currently mentioning Redis Enterprise.

@muthu-mps, I have update the description. Can you please review it?

muthu-mps
muthu-mps approved these changes Apr 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit c440c15 into elastic:main Apr 6, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 6, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 6, 2023

Package cassandra - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=cassandra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muthu-mps muthu-mps muthu-mps approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

enhancement New feature or request Integration:cassandra Cassandra Team:Service-Integrations Label for the Observability Service Integrations team v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rajvi-patel-22 @elasticmachine @agithomas @muthu-mps @kush-elastic