Skip to content

[O11y][Cassandra] Migrate Overview dashboard visualizations to lens in kibana 8.3.0 #5714

Merged
kush-elastic merged 3 commits intoelastic:mainfrom
rajvi-patel-22:len_migration-cassandra-metrics-8.3.0
Apr 6, 2023
Merged

[O11y][Cassandra] Migrate Overview dashboard visualizations to lens in kibana 8.3.0 #5714
kush-elastic merged 3 commits intoelastic:mainfrom
rajvi-patel-22:len_migration-cassandra-metrics-8.3.0

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 28, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Cassandra integration package

  • Statistics for Cassandra Lens migration:

  Before Migration   After Migration     
  Lens Visualization Lens Visualization New Control Panel
[Metrics Cassandra] Overview 0 19 17 1 (Markdown) 1
  0 19 17 1 (Markdown) 1

Note:

  • 1 visualization is migrated to new control panels.
  • 1 visualization is markdown which can not be migrated to the lens.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

Notes: As per the discussion, the Cluster Info [Metrics Cassandra] donut chart is converted to table due to limitation of split size in lens.

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 28, 2023 12:49
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 28, 2023
Closed
6 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-03T10:59:15.139+0000

  • Duration: 16 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (13/13) 💚
Lines 91.228% (52/57) 👎 -6.468
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic added v8.3.0 enhancement New feature or request Integration:cassandra Cassandra Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 28, 2023
@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 30, 2023

@rajvi-elastic , please complete peer review

@SubhrataK , JFYI, i noticed the change from Donut Chart to Table representation for representing the cluster information and i agree with the change. Hope you are good too.

@muthu-mps
Copy link
Copy Markdown
Contributor

muthu-mps commented Mar 30, 2023

@rajvi-elastic,

  • Please change the description of the issue which represents Redis Enterprise
  • When replacing the control filter the current integration enables the Database selection based on the host selection. Are we having the same functionality in the control panel migration. If not is this captured somewhere ?

@SubhrataK - Please let me know your thought process on the mentions below.

  • Can we make Node and Cluster Info tables to the fit in the entire screen ?
  • The Read Latency, Write Latency and Range Slice Latency all together looks cluttered. Can we realign ?
  • Similarly for Storage Exception and Unavailable Requests.

@muthu-mps muthu-mps self-requested a review March 30, 2023 05:06
@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Mar 30, 2023

@rajvi-elastic,

  • Please change the description of the issue which represents Redis Enterprise
  • When replacing the control filter the current integration enables the Database selection based on the host selection. Are we having the same functionality in the control panel migration. If not is this captured somewhere ?

@muthu-mps,

  1. Updated the description.
  2. No in the new control panels dependency filtering is not possible. We have mentioned this issue in the meta in below format.

In input control visualization, we can make dependency filters that strictly depend on each other but in new controls, dependency filtering is possible but filters are not required to be strict. As per the #4768 (comment), this is the expected behavior of new controls.
Impact : [ Severity : Low, Workaround : No (Expected Behaviour) ]

@kush-elastic kush-elastic self-requested a review March 31, 2023 07:02
kush-elastic
kush-elastic approved these changes Mar 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Mar 31, 2023

@SubhrataK - Please let me know your thought process on the mentions below.

  • Can we make Node and Cluster Info tables to the fit in the entire screen ?
  • The Read Latency, Write Latency and Range Slice Latency all together looks cluttered. Can we realign ?
  • Similarly for Storage Exception and Unavailable Requests.

As discussed with @SubhrataK, created issue to update service.address field: #5766

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Mar 31, 2023

  • Can we make Node and Cluster Info tables to the fit in the entire screen ?
  • The Read Latency, Write Latency and Range Slice Latency all together looks cluttered. Can we realign ?
  • Similarly for Storage Exception and Unavailable Requests.

I will update the PR with mentioned changes.

CC: @SubhrataK

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Apr 3, 2023

  • Can we make Node and Cluster Info tables to the fit in the entire screen ?
  • The Read Latency, Write Latency and Range Slice Latency all together looks cluttered. Can we realign ?
  • Similarly for Storage Exception and Unavailable Requests.

@muthu-mps, I have updated the PR with mentioned changes after discussing with @SubhrataK. Can you please review it?

muthu-mps
muthu-mps approved these changes Apr 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@kush-elastic kush-elastic merged commit 28f00cb into elastic:main Apr 6, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 6, 2023

Package cassandra - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=cassandra

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 6, 2023
Closed
@milan-elastic milan-elastic mentioned this pull request Jun 6, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muthu-mps muthu-mps muthu-mps approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

enhancement New feature or request Integration:cassandra Cassandra Team:Service-Integrations Label for the Observability Service Integrations team v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rajvi-patel-22 @elasticmachine @agithomas @muthu-mps @kush-elastic