Skip to content

[O11y][ZooKeeper] Lens migration for visualizations to Kibana version 8.2.0#5691

Merged
kush-elastic merged 3 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-zookeeper-8.2.0
Mar 30, 2023
Merged

[O11y][ZooKeeper] Lens migration for visualizations to Kibana version 8.2.0#5691
kush-elastic merged 3 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-zookeeper-8.2.0

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 27, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for ZooKeeper integration package

  • Statistics for ZooKeeper Lens migration:

Zookeeper dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics Zookeeper] Overview 0 5 5 0
  0 5 5 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.2.0 itself.

Related issues

Issues Identified

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 27, 2023 06:01
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 27, 2023
Closed
5 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 27, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-28T13:04:50.386+0000

  • Duration: 13 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 27, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (6/9) 👎 -33.333
Lines 100.0% (0/0) 💚 24.522
Conditionals 100.0% (0/0) 💚

agithomas
agithomas approved these changes Mar 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It may be best to add the unit of latency in the Y-axis for the latency panel.

If you can add the unit in the Y-axis for the latency, it will be good. If it is a time taking thing, please create a backlog ticket

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Mar 28, 2023

If you can add the unit in the Y-axis for the latency, it will be good. If it is a time taking thing, please create a backlog ticket

Yes @agithomas. We can add the unit in Y-axis label. As per the readme file the latency is measured in milliseconds. So we will add ms suffix to the Y-axis.

@kush-elastic kush-elastic self-requested a review March 28, 2023 13:05
@kush-elastic kush-elastic added enhancement New feature or request Integration:zookeeper ZooKeeper Metrics v8.2.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 28, 2023
agithomas
agithomas approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please complete the peer review

kush-elastic
kush-elastic approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 130a39b into elastic:main Mar 30, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 30, 2023

Package zookeeper - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=zookeeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

enhancement New feature or request Integration:zookeeper ZooKeeper Metrics Team:Service-Integrations Label for the Observability Service Integrations team v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajvi-patel-22 @elasticmachine @kush-elastic @agithomas