Skip to content

[O11y][Redis Enterprise] Migrate visualizations to lens in Kibana 8.3.0#5678

Merged
kush-elastic merged 2 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-redis-enterprise-8.3.0
Mar 28, 2023
Merged

[O11y][Redis Enterprise] Migrate visualizations to lens in Kibana 8.3.0#5678
kush-elastic merged 2 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-redis-enterprise-8.3.0

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 24, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Redis Enterprise integration package

  • Statistics for Redis Enterprise Lens migration:

Redis Enterprise dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metricbeat Redis Enterprise] Overview 0 12 11 0
  0 12 11 0
Note: Migrate 1 visualization to new control panel.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 24, 2023 13:09
@kush-elastic kush-elastic added enhancement New feature or request v8.3.0 Integration:redisenterprise Redis Enterprise Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 24, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 24, 2023
Closed
6 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 24, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-24T13:11:36.704+0000

  • Duration: 13 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 50.0% (4/8) 👍 16.667
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

agithomas
agithomas approved these changes Mar 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 27, 2023

Please complete the peer review

kush-elastic
kush-elastic reviewed Mar 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you upload the screenshot before migration which populates all the panels to confirm that type of chart has not been changed? As I can see 3 of the panels are not populated!

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Mar 28, 2023

Can you upload the screenshot before migration which populates all the panels to confirm that type of chart has not been changed? As I can see 3 of the panels are not populated!

Sure! Please find the below screenshot before migration.
redis-enterprise

kush-elastic
kush-elastic approved these changes Mar 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit c244691 into elastic:main Mar 28, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 28, 2023

Package redisenterprise - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=redisenterprise

@ritalwar ritalwar mentioned this pull request Nov 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

enhancement New feature or request Integration:redisenterprise Redis Enterprise Team:Service-Integrations Label for the Observability Service Integrations team v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajvi-patel-22 @elasticmachine @agithomas @kush-elastic