Skip to content

system: clean up windows dashboards#5653

Merged
efd6 merged 10 commits intoelastic:mainfrom
efd6:5022-cleanup
Mar 28, 2023
Merged

system: clean up windows dashboards#5653
efd6 merged 10 commits intoelastic:mainfrom
efd6:5022-cleanup

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Mar 23, 2023 •
edited by andrewkroh
Loading

What does this PR do?

This does a general clean up of the Windows dashboards. Each commit is a distinct operation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

system-windows-overview
system-windows-security-user-logons
system-windows-security-failed-and-blocked-accounts
system-windows-security-user-management-events
system-windows-security-group-management-events

@efd6 efd6 requested a review from a team March 23, 2023 06:10
@efd6 efd6 self-assigned this Mar 23, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-28T05:39:34.217+0000

  • Duration: 15 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 3.31
Classes 100.0% (4/4) 💚 3.31
Methods 60.759% (48/79) 👎 -30.847
Lines 99.535% (2780/2793) 👍 8.26
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review March 23, 2023 07:46
@efd6 efd6 requested review from a team as code owners March 23, 2023 07:47
@efd6 efd6 requested review from belimawr and cmacknz March 23, 2023 07:47
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 23, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Mar 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If modifying the dashboard filters is in scope for this PR, then for [System] Windows Overview can you add winlog.winlog to include the default data_stream.dataset used by the Custom Windows events input package.

The other four [System Windows Security] * dashboards are all looking at data from winlog.provider_name: Microsoft-Windows-Security-Auditing. So I think we should add that as a dashboard filter. I think those four should also include windows.forwarded in the data_stream.dataset filter since we can have forwarded auditing events in that channel.

I posted some screenshots to the description. I used the elastic-package install command to install this to https://kibana.siem.estc.dev.

@efd6
Copy link
Copy Markdown
Contributor Author

efd6 commented Mar 24, 2023 •
edited
Loading

@andrewkroh I've added those (caution: winlog.provider_name: Microsoft-Windows-Security-Auditing added manually since I don't have an easy windows datastream here, so winlog.* gives a warning on the dashboard). PTAL

@efd6 efd6 merged commit d3a2afa into elastic:main Mar 28, 2023
@efd6 efd6 deleted the 5022-cleanup branch February 5, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr was automatically assigned from elastic/elastic-agent-data-plane

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:system System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @andrewkroh @fearful-symmetry