Skip to content

[O11y][Hadoop] Migrate node_manager and data_node dashboards visualizations to lens in kibana 8.3.0#5605

Merged
kush-elastic merged 3 commits intoelastic:mainfrom
chavdaharnish:lens_migration-hadoop-data_node-node_manager-8.3.0
Mar 28, 2023
Merged

[O11y][Hadoop] Migrate node_manager and data_node dashboards visualizations to lens in kibana 8.3.0#5605
kush-elastic merged 3 commits intoelastic:mainfrom
chavdaharnish:lens_migration-hadoop-data_node-node_manager-8.3.0

Conversation

@harnish-crest-data
Copy link
Copy Markdown
Contributor

@harnish-crest-data harnish-crest-data commented Mar 21, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Hadoop integration package

  • Statistics for Hadoop Lens migration:

Hadoop dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics Hadoop] Data nodes 6 3 9 0
[Metrics Hadoop] Node Manager 0 3 3 0
  6 6 12 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0.

Related issues

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T13:04:44.519+0000

  • Duration: 21 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (47/47) 💚 10.909
Lines 99.18% (605/610) 👍 9.922
Conditionals 100.0% (0/0) 💚

This was referenced Mar 21, 2023
Closed
Closed
@harnish-crest-data harnish-crest-data marked this pull request as ready for review March 21, 2023 11:05
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner March 21, 2023 11:05
@kush-elastic kush-elastic added enhancement New feature or request Integration:hadoop Hadoop v8.3.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 21, 2023
kush-elastic
kush-elastic approved these changes Mar 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas reviewed Mar 21, 2023
View reviewed changes
packages/hadoop/changelog.yml Outdated
# newer versions go on top
- version: "0.5.0"
changes:
- description: Migrate `[Metrics Hadoop] Data nodes` and `[Metrics Hadoop] Node Manager` dashboard visualizations to lens.
Copy link
Copy Markdown
Contributor

@agithomas agithomas Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed to add [Metric Hadoop] string in the changelog

Copy link
Copy Markdown
Contributor Author

@harnish-crest-data harnish-crest-data Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 22, 2023

image

I assume, the panel at the top is the time duration it takes .
In the panel below, does the "Duration" text in the "Container Launch Duration (Num of operation) " make sense? Please change from Num of operation to Operation Count.

@harnish-crest-data
Copy link
Copy Markdown
Contributor Author

harnish-crest-data commented Mar 22, 2023

image

I assume, the panel at the top is the time duration it takes . In the panel below, does the "Duration" text in the "Container Launch Duration (Num of operation) " make sense? Please change from Num of operation to Operation Count.

This name is already there in the current codebase. This is just the lens migration PR so we won't be changing any behavior as a part of this PR otherwise it will mess it up. However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately.

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 22, 2023

This name is already there in the current codebase. This is just the lens migration PR so we won't be changing any behavior as a part of this PR otherwise it will mess it up. However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately.

As you think that the change will complicate the PR, continue with the same scope.

agithomas
agithomas approved these changes Mar 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kush-elastic kush-elastic merged commit 28f8ec3 into elastic:main Mar 28, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 28, 2023

Package hadoop - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=hadoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

enhancement New feature or request Integration:hadoop Hadoop Team:Service-Integrations Label for the Observability Service Integrations team v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harnish-crest-data @elasticmachine @agithomas @kush-elastic