Skip to content

[Apache] Fix a bug that may blank three visualizations#5576

Merged
sakurai-youhei merged 2 commits intoelastic:mainfrom
sakurai-youhei:fix-apache-visualizations
Mar 24, 2023
Merged

[Apache] Fix a bug that may blank three visualizations#5576
sakurai-youhei merged 2 commits intoelastic:mainfrom
sakurai-youhei:fix-apache-visualizations

Conversation

@sakurai-youhei
Copy link
Copy Markdown
Member

@sakurai-youhei sakurai-youhei commented Mar 17, 2023 •
edited
Loading

What does this PR do?

Fixes the issue described at #5560

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • n/a I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

EDIT: Corrected the 3rd item in the check list, which was wrongly marked as n/a.

@sakurai-youhei sakurai-youhei added bug Something isn't working, use only for issues Integration:apache Apache HTTP Server labels Mar 17, 2023
@sakurai-youhei sakurai-youhei requested a review from a team as a code owner March 17, 2023 13:06
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-17T13:06:27.380+0000

  • Duration: 17 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 44
Skipped 0
Total 44

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 17, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👎 -46.568
Classes 50.0% (2/4) 👎 -46.568
Methods 70.0% (28/40) 👎 -21.16
Lines 70.234% (210/299) 👎 -21.148
Conditionals 100.0% (0/0) 💚

agithomas
agithomas approved these changes Mar 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas mentioned this pull request Mar 23, 2023
Closed
6 tasks
@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 23, 2023

@sakurai-youhei , do you have the permission to merge? If yes, please proceed with the merge.

@sakurai-youhei sakurai-youhei merged commit de302a9 into elastic:main Mar 24, 2023
@sakurai-youhei
Copy link
Copy Markdown
Member Author

sakurai-youhei commented Mar 24, 2023

@agithomas Thank you for your review! I find I have the permission. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues Integration:apache Apache HTTP Server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Apache] Some visualizations may become blank

3 participants

@sakurai-youhei @elasticmachine @agithomas