Skip to content

[O11y][Oracle WebLogic] Lens migration for visualizations to kibana version 8.4.0#5548

Merged
kush-elastic merged 2 commits intoelastic:mainfrom
chavdaharnish:lens_migration-oracle_weblogic-8.4.0
Mar 22, 2023
Merged

[O11y][Oracle WebLogic] Lens migration for visualizations to kibana version 8.4.0#5548
kush-elastic merged 2 commits intoelastic:mainfrom
chavdaharnish:lens_migration-oracle_weblogic-8.4.0

Conversation

@harnish-crest-data
Copy link
Copy Markdown
Contributor

@harnish-crest-data harnish-crest-data commented Mar 15, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Oracle WebLogic integration package

  • Statistics for Oracle WebLogic Lens migration:

Oracle WebLogic dashboards  Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics Oracle WebLogic] Deployed Application 5 2 7 0
[Logs Oracle WebLogic] Logs Overview 3 8 7 4
[Metrics Oracle WebLogic] ThreadPool 8 1 9 0
  16 11 23 4

  • 4 visualizations are markdown visualizations which won't be converted to lens.

  • Updated TagCloud visualizations to the horizontal bar chart. For that, changed the visualization name from Request Endpoint [Logs Oracle WebLogic] to Top values of Request Endpoint [Logs Oracle WebLogic]

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

@harnish-crest-data harnish-crest-data mentioned this pull request Mar 15, 2023
Closed
10 tasks
@harnish-crest-data harnish-crest-data marked this pull request as ready for review March 15, 2023 16:47
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner March 15, 2023 16:47
@kush-elastic kush-elastic added enhancement New feature or request v8.4.0 Team:Service-Integrations Label for the Observability Service Integrations team Integration:oracle_weblogic Oracle WebLogic labels Mar 15, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-16T05:17:01.554+0000

  • Duration: 26 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 49
Skipped 0
Total 49

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 15, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.459
Classes 100.0% (4/4) 💚 3.459
Methods 100.0% (44/44) 💚 9.063
Lines 100.0% (239/239) 💚 8.622
Conditionals 100.0% (0/0) 💚

kush-elastic
kush-elastic approved these changes Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM1

@agithomas agithomas dismissed their stale review March 17, 2023 14:48

Waiting for more clarification

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 17, 2023 •
edited
Loading

Any reason why coreMigrationVersion and migrationVersion.lens are different?. Are export dashboard method consistently used and no manual overriding done?

@harnish-crest-data
Copy link
Copy Markdown
Contributor Author

harnish-crest-data commented Mar 20, 2023

Any reason why coreMigrationVersion and migrationVersion.lens are different?. Are export dashboard method consistently used and no manual overriding done?

We are using elastic-package export dashboards command while exporting the dashboards. We are not manually overriding it. We are not sure of above two fields difference.

agithomas
agithomas approved these changes Mar 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit e9ae4b5 into elastic:main Mar 22, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 22, 2023

Package oracle_weblogic - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

enhancement New feature or request Integration:oracle_weblogic Oracle WebLogic Team:Service-Integrations Label for the Observability Service Integrations team v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harnish-crest-data @elasticmachine @agithomas @kush-elastic