Skip to content

[O11y][InfluxDB] Lens migration for visualizations to Kibana version 8.3.0#5510

Merged
kush-elastic merged 5 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-influxdb-8.3.0
Mar 28, 2023
Merged

[O11y][InfluxDB] Lens migration for visualizations to Kibana version 8.3.0#5510
kush-elastic merged 5 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-influxdb-8.3.0

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 10, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for InfluxDB integration package

  • Statistics for InfluxDB Lens migration:

  Before Migration   After Migration  
  Lens Visualization Lens Visualization
[InfluxDB Metrics] Advanced Status Metrics 0 9 9 0
[InfluxDB Metrics] Status Metrics 0 18 18 0
  0 27 27 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

Issues Identified

Note: The size of panels has not been changed in [InfluxDB Metrics] Advanced Status Metrics dashboard. The screenshot of [InfluxDB Metrics] Advanced Status Metrics dashboard and Kibana files are not synced. Please consider below screenshots to compare the migration changes.

[InfluxDB Metrics] Advanced Status Metrics dashboard before migration:
screencapture-storage-0-kb-us-central1-gcp-cloud-es-io-9243-app-dashboards-2023-03-21-13_07_56

[InfluxDB Metrics] Advanced Status Metrics dashboard after migration:
image

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 10, 2023 16:04
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 10, 2023
Closed
6 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 10, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-23T10:37:34.963+0000

  • Duration: 16 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 10, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (6/8) 👎 -18.333
Lines 100.0% (0/0) 💚 2.959
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:influxdb InfluxDb labels Mar 10, 2023
kush-elastic
kush-elastic approved these changes Mar 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic added v8.3.0 Team:Service-Integrations Label for the Observability Service Integrations team enhancement New feature or request and removed dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:influxdb InfluxDb labels Mar 13, 2023
@agithomas agithomas requested a review from ritalwar March 14, 2023 14:20
ritalwar
ritalwar reviewed Mar 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image size for advstatus.png and status.png is way too reduced compared to earlier ones.
There is no data for shard disk size in status.png, can we replace it with the one having some data in it?

Also, can you please resolve conflicts on this branch?

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Mar 22, 2023

Image size for advstatus.png and status.png is way too reduced compared to earlier ones. There is no data for shard disk size in status.png, can we replace it with the one having some data in it?

Also, can you please resolve conflicts on this branch?

@ritalwar Can you please check the description, I have uploaded the screenshot of dashboard before migration as we haven't changed the size of panels. It seems like screenshots were not synced with Kibana files.

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 22, 2023

Please address the conflicts.

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Mar 23, 2023

@agithomas, Merge conflicts has been resolved.

As per the changes done in this TSDB PR, the Kibana version was updated from 8.3.0 to 8.6.0. Previously, we manually migrated the visualizations to 8.3.0 itself. Now we exported dashboards from 8.6.0. So, there will be version changes in the json files from 8.3.0 -> 8.6.0.

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 24, 2023

LGTM!

agithomas
agithomas approved these changes Mar 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit c51bc8c into elastic:main Mar 28, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 28, 2023

Package influxdb - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=influxdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ritalwar ritalwar ritalwar left review comments

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

@rameshelastic rameshelastic Awaiting requested review from rameshelastic

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

enhancement New feature or request Team:Service-Integrations Label for the Observability Service Integrations team v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rajvi-patel-22 @elasticmachine @agithomas @kush-elastic @ritalwar