Skip to content

Filter by empty aws.dimensions.TransitGatewayAttachment in transitgat…#5499

Closed
francescayeye wants to merge 2 commits intoelastic:mainfrom
francescayeye:filter-by-empty-transitgateway-attachment
Closed

Filter by empty aws.dimensions.TransitGatewayAttachment in transitgat…#5499
francescayeye wants to merge 2 commits intoelastic:mainfrom
francescayeye:filter-by-empty-transitgateway-attachment

Conversation

@francescayeye
Copy link
Copy Markdown

@francescayeye francescayeye commented Mar 10, 2023

…eway dashboard

Bug

What does this PR do?

Transitgateway metrics are reported with two dimensions:

  • aws.dimensions.TransitGateway
  • aws.dimensions.TransitGatewayAttachment

The sum of the metrics with the same aws.dimensions.TransitGateway value and different aws.dimensions.TransitGatewayAttachment values is equal to the value of the metrics with the same aws.dimensions.TransitGateway value only and empty aws.dimensions.TransitGatewayAttachment.
The dashboard for the integration shows stats at aws.dimensions.TransitGateway level, and not at aws.dimensions.TransitGatewayAttachment. Therefore we have to filter by empty aws.dimensions.TransitGatewayAttachment values, so that the values showed in the dashboard are not doubled respect their reality.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
  • [] I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@francescayeye francescayeye requested review from a team as code owners March 10, 2023 05:43
@francescayeye francescayeye self-assigned this Mar 10, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 10, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-10T05:44:20.608+0000

  • Duration: 56 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -2.823
Classes 93.75% (15/16) 👎 -2.823
Methods 86.131% (236/274) 👎 -5.114
Lines 85.925% (7387/8597) 👎 -5.461
Conditionals 100.0% (0/0) 💚

@kylemclaren kylemclaren mentioned this pull request Mar 10, 2023
Closed
drewdaemon
drewdaemon approved these changes Mar 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change make sense to me!

@francescayeye francescayeye mentioned this pull request Mar 27, 2023
Merged
4 tasks
@botelastic
Copy link
Copy Markdown

botelastic bot commented Apr 9, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 9, 2023
@botelastic
Copy link
Copy Markdown

botelastic bot commented May 9, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees

@francescayeye francescayeye

Labels

Stalled

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francescayeye @elasticmachine @drewdaemon