Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
jlind23
left a comment
There was a problem hiding this comment.
Looks good to me. @leehinman @fearful-symmetry can I have 👀 on this?
leehinman
left a comment
There was a problem hiding this comment.
Overall looks good. Just one question on a query for docker-fleet-agent.
| "query": { | ||
| "language": "kuery", | ||
| "query": "" | ||
| "query": "host.name:\"docker-fleet-agent\"" |
There was a problem hiding this comment.
what is this query for? I don't remember the system dashboard having a query for docker-fleet-agent specifically.
There was a problem hiding this comment.
You are right, there should not be a filter like that... I probably slipped up while modifying the dashboards... I will check it
There was a problem hiding this comment.
Pushed a fixup without that filter.. I didn't realize that would be added when navigating from the system overview to the host overview by clicking on a hostname so when I modified the dashboard that got saved and exported as well 😅
Nice catch! 👍
|
Package system - 1.24.1 containing this change is available at https://epr.elastic.co/search?package=system |
What does this PR do?
Added
datasetfilters for system metrics dashboardsChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots