Skip to content

[fim] Fix for duplicate processor key#5196

Merged
ShourieG merged 4 commits intoelastic:mainfrom
ShourieG:bugfix/fim-3018
Feb 7, 2023
Merged

[fim] Fix for duplicate processor key#5196
ShourieG merged 4 commits intoelastic:mainfrom
ShourieG:bugfix/fim-3018

Conversation

@ShourieG
Copy link
Copy Markdown
Contributor

@ShourieG ShourieG commented Feb 7, 2023

Type of change

Please label this PR with one of the following labels, depending on the scope of your change:

  • Bug

What does this PR do?

Fixes for a SDH involving a duplicate key issue which prevented processors from being added in the config.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ShourieG ShourieG requested a review from a team as a code owner February 7, 2023 08:26
@ShourieG ShourieG self-assigned this Feb 7, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 7, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@ShourieG ShourieG changed the title removed duplicate processor key [fim] Fix for duplicate processor key Feb 7, 2023
@kcreddy kcreddy added Integration:fim File Integrity Monitoring bug Something isn't working, use only for issues labels Feb 7, 2023
kcreddy
kcreddy approved these changes Feb 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-07T08:29:06.930+0000

  • Duration: 14 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (3/4) 👎 -25.0
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@ShourieG ShourieG merged commit 7f74397 into elastic:main Feb 7, 2023
@ShourieG ShourieG deleted the bugfix/fim-3018 branch February 7, 2023 09:13
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 7, 2023

Package fim - 1.4.2 containing this change is available at https://epr.elastic.co/search?package=fim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@ShourieG ShourieG

Labels

8.7 candidate bug Something isn't working, use only for issues Integration:fim File Integrity Monitoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShourieG @elasticmachine @kcreddy