Skip to content

Update system integration data streams to beta#5119

Merged
fearful-symmetry merged 5 commits intoelastic:mainfrom
fearful-symmetry:update-system-ga
Jan 30, 2023
Merged

Update system integration data streams to beta#5119
fearful-symmetry merged 5 commits intoelastic:mainfrom
fearful-symmetry:update-system-ga

Conversation

@fearful-symmetry
Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry commented Jan 26, 2023

What does this PR do?

Closes #5116

cc @mukeshelastic @cmacknz

This updates all the system integrations from experimental to beta.

For reasons I don't quite understand, the elastic-package linter doesn't allow you to mark data streams as ga, only integrations themselves.

There was some discussion over marking certain data streams as GA based on gaps in the OS support, but if we're just marking them as beta, I'm not sure if that still applies.

@fearful-symmetry fearful-symmetry added bug Something isn't working, use only for issues Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] labels Jan 26, 2023
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner January 26, 2023 19:28
@fearful-symmetry fearful-symmetry self-assigned this Jan 26, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 26, 2023

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 26, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-27T23:51:43.957+0000

  • Duration: 15 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 0
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 26, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 2.284
Classes 100.0% (4/4) 💚 2.284
Methods 60.759% (48/79) 👎 -30.764
Lines 99.533% (2771/2784) 👍 6.669
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Jan 26, 2023

For reasons I don't quite understand, the elastic-package linter doesn't allow you to mark data streams as ga, only integrations themselves.

@kpollich do you know why this is?

@leehinman
Copy link
Copy Markdown
Contributor

leehinman commented Jan 26, 2023

For reasons I don't quite understand, the elastic-package linter doesn't allow you to mark data streams as ga, only integrations themselves.

@kpollich do you know why this is?

because it isn't an accepted value in the spec file. For data streams having no release means you are GA.
https://github.com/elastic/package-spec/blob/002da3782ec4e1c2de96edf1f56b46392477e8a1/spec/integration/data_stream/manifest.spec.yml#LL154-L158C13

And marking the release status of the integration is deprecated. https://github.com/elastic/package-spec/blob/002da3782ec4e1c2de96edf1f56b46392477e8a1/spec/integration/manifest.spec.yml#L346

@fearful-symmetry
Copy link
Copy Markdown
Contributor Author

fearful-symmetry commented Jan 27, 2023

Well, that adds a little bit of complexity. Do we want to remove the release tags from the data streams to mark them as GA? Should we also remove the integration-level release tag while we're at it?

@leehinman
Copy link
Copy Markdown
Contributor

leehinman commented Jan 27, 2023

Well, that adds a little bit of complexity. Do we want to remove the release tags from the data streams to mark them as GA? Should we also remove the integration-level release tag while we're at it?

My preference would be for the system integration to be like other integrations, so it appears in the UI the same way other integrations do. So yes to removing release tag on integration (since it is 1.22.1) and removing release tag on data streams that are GA.

@fearful-symmetry
Copy link
Copy Markdown
Contributor Author

fearful-symmetry commented Jan 27, 2023

Okay, now we should be good.

leehinman
leehinman requested changes Jan 27, 2023
View reviewed changes
@fearful-symmetry @leehinman
Update packages/system/changelog.yml
c13458b 
Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
leehinman
leehinman approved these changes Jan 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fearful-symmetry fearful-symmetry merged commit 5fea958 into elastic:main Jan 30, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 30, 2023

Package system - 1.23.1 containing this change is available at https://epr.elastic.co/search?package=system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz approved these changes

@leehinman leehinman leehinman approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr was automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@fearful-symmetry fearful-symmetry

Labels

bug Something isn't working, use only for issues Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System data streams are all marked as experimental

4 participants

@fearful-symmetry @elasticmachine @cmacknz @leehinman