[Windows] Added support for custom processors on perfmon#4956
[Windows] Added support for custom processors on perfmon#4956andrewkroh merged 6 commits intomainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
left a comment
There was a problem hiding this comment.
There needs to be a change to the config file to utilize these processors you added to the manfiest.
perfmon/agent/stream/stream.yml.hbs:
{{#if processors}}
processors:
{{processors}}
{{/if}}|
@andrewkroh somehow I am still missing something? |
packages/windows/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.15.3" | |||
There was a problem hiding this comment.
The version contained in the windows/manifest.yml needs updated to 1.15.3. CI is complaining about:
[2023-01-19T12:54:34.746Z] Error: checking package failed: linting package failed: found 1 validation error:
[2023-01-19T12:54:34.746Z] 1. current manifest version doesn't have changelog entry
I would say this is a new feature rather than a bug fix so using 1.16.0 would be more appropriate under semver.org rules.
There was a problem hiding this comment.
Would love to know what I did wrong. I added 1.15.3 back then and now changed it to 1.16, but it still error with:
[2023-01-20T09:31:58.481Z] Error: checking package failed: linting package failed: found 1 validation error:
[2023-01-20T09:31:58.481Z] 1. current manifest version doesn't have changelog entry
There was a problem hiding this comment.
I think there's a check the verifies that the latest changelog entry matches the version contained in the manefest.yml. So until those two values are the same we will get this type of error.
🌐 Coverage report
|
|
@elastic/elastic-agent-data-plane As the package owner, are you good with these changes? |
|
Package windows - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=windows |
What does this PR do?
Adds support for the custom processor definition in windows perfmon.
Checklist
changelog.ymlfile.