[Elasticsearch] Added ssl configuration to ES module#4946
Merged
mohamedhamed-ahmed merged 1 commit intoelastic:mainfrom Jan 9, 2023
Merged
Conversation
Contributor
Author
After taking a look at metricbeat module it seems that it doesn't support api_key authorization which is also proven by the ticket Kevin linked above. The change seems to be a bit bigger and separate from the scope of this ticket and I would suggest having a separate ticket for it. The necessary changes as per my understanding are as follows:
|
4 tasks
🌐 Coverage report
|
klacabane
approved these changes
Jan 9, 2023
Contributor
|
LGTM. Let's create a follow up (or update the existing ticket with the findings) for adding api key support in metricbeat module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
sslconfiguration options for elasticsearch integration moduleChecklist
changelog.ymlfile.How to this PR was tested
Related issues